Skip to content

Commit

Permalink
Add build_type to datasource github_repository's pages (#1710)
Browse files Browse the repository at this point in the history
PR #1663 added the "build_type" attribute to the github_repository resource.
Since the corresponding data source uses the same code to parse the pages
endpoint data, any use of the github_repository datasource would lead to an
error, since the attribute did not exist there:

> Error: error setting pages: Invalid address to set: []string{"pages", "0", "build_type"}

This commit adds the missing attribute. The existing acceptance tests already
cover it, failed for me when running without this commit, and passed after.

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
  • Loading branch information
soult and kfcampbell authored Jun 14, 2023
1 parent 6b98ac5 commit a7474e7
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions github/data_source_github_repository.go
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,10 @@ func dataSourceGithubRepository() *schema.Resource {
},
},
},
"build_type": {
Type: schema.TypeString,
Computed: true,
},
"cname": {
Type: schema.TypeString,
Computed: true,
Expand Down

0 comments on commit a7474e7

Please sign in to comment.