Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] support requiring "signed commits" on github_branch_protection #87

Closed
majormoses opened this issue Apr 28, 2018 · 3 comments · Fixed by #214
Closed

[Feature Request] support requiring "signed commits" on github_branch_protection #87

majormoses opened this issue Apr 28, 2018 · 3 comments · Fixed by #214
Labels
Type: Feature New feature or request Upstream

Comments

@majormoses
Copy link
Contributor

Affected Resource(s)

Please list the resources as a list, for example:

  • github_branch_protection

Important Factoids

Some organizations require commits to be signed to verify identity of submitter for legal reasons.

It is available in the rest api: https://developer.github.com/v3/repos/branches/#add-required-signatures-of-protected-branch but I do not see it yet in the upstream go library: https://github.com/google/go-github/blob/v15.0.0/github/repos.go so we are blocked until it is added. I have created google/go-github#902 upstream to track.

image
@radeksimko radeksimko added the Type: Feature New feature or request label Aug 2, 2018
@majormoses
Copy link
Contributor Author

The functionality has been merged upstream into master but has not been released yet.

@travispaul
Copy link

Hi @majormoses, are you aware of an ETA for the next release?

Thanks in advance.

@majormoses
Copy link
Contributor Author

It looks like its present in the latest version: https://github.com/google/go-github/tree/v19.1.0

bramwelt added a commit to bramwelt/terraform-provider-github that referenced this issue Mar 17, 2019
@bramwelt
Branch Protection features: signed commits, approval numbers
0d41c46 
Add the ability to manage branch protection state of whether or not
signed commits are required along with the number of approvals needed.

Resolves: integrations#87

Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
@bramwelt bramwelt mentioned this issue Mar 22, 2019
Closed
bltavares referenced this issue in bltavares/terraform-provider-github Apr 23, 2019
@bltavares
Provide "require signed commits" on github_branch_protection
8ee9906 
This commit provides changing the toggle to require signed commits on
branch protection.

The [API for signed commits](https://developer.github.com/v3/repos/branches/#get-required-signatures-of-protected-branch)
is separate endpoint from the branch protection url, and does not come on the same payload.
This means that we need to make an extra request to read and modify it.

This changes requires `go-github` at least v19.

Need:
 - [ ] Update `go-github` version: https://github.com/terraform-providers/terraform-provider-github/pull/207
 - [ ] Provide default required reviewers count to avoid GitHub update error: https://github.com/terraform-providers/terraform-provider-github/pull/211
Closes https://github.com/terraform-providers/terraform-provider-github/issues/87
@bltavares bltavares mentioned this issue Apr 23, 2019
Closed
2 tasks
bltavares referenced this issue in bltavares/terraform-provider-github Apr 24, 2019
@bltavares
Provide "require signed commits" on github_branch_protection
fb80993 
This commit provides changing the toggle to require signed commits on
branch protection.

The [API for signed commits](https://developer.github.com/v3/repos/branches/#get-required-signatures-of-protected-branch)
is separate endpoint from the branch protection url, and does not come on the same payload.
This means that we need to make an extra request to read and modify it.

This changes requires `go-github` at least v19.

Need:
 - [ ] Update `go-github` version: https://github.com/terraform-providers/terraform-provider-github/pull/207
 - [ ] Provide default required reviewers count to avoid GitHub update error: https://github.com/terraform-providers/terraform-provider-github/pull/211
Closes https://github.com/terraform-providers/terraform-provider-github/issues/87
@bltavares bltavares mentioned this issue Apr 24, 2019
Merged
bltavares referenced this issue in bltavares/terraform-provider-github Apr 24, 2019
@bltavares
Provide "require signed commits" on github_branch_protection
a93cf11 
This commit provides changing the toggle to require signed commits on
branch protection.

The [API for signed commits](https://developer.github.com/v3/repos/branches/#get-required-signatures-of-protected-branch)
is separate endpoint from the branch protection url, and does not come on the same payload.
This means that we need to make an extra request to read and modify it.

This changes requires `go-github` at least v19.

Need:
 - [ ] Update `go-github` version: https://github.com/terraform-providers/terraform-provider-github/pull/207
 - [ ] Provide default required reviewers count to avoid GitHub update error: https://github.com/terraform-providers/terraform-provider-github/pull/211
Closes https://github.com/terraform-providers/terraform-provider-github/issues/87
bltavares referenced this issue in bltavares/terraform-provider-github May 2, 2019
@bltavares
Provide "require signed commits" on github_branch_protection
eaa247d 
This commit provides changing the toggle to require signed commits on
branch protection.

The [API for signed commits](https://developer.github.com/v3/repos/branches/#get-required-signatures-of-protected-branch)
is separate endpoint from the branch protection url, and does not come on the same payload.
This means that we need to make an extra request to read and modify it.

This changes requires `go-github` at least v19.

Need:
 - [ ] Update `go-github` version: https://github.com/terraform-providers/terraform-provider-github/pull/207
 - [ ] Provide default required reviewers count to avoid GitHub update error: https://github.com/terraform-providers/terraform-provider-github/pull/211
Closes https://github.com/terraform-providers/terraform-provider-github/issues/87
tracypholmes referenced this issue Jun 27, 2019
@bltavares @tracypholmes
Provide "require signed commits" on github_branch_protection (#214)
832ea7e 
* Provide "require signed commits" on `github_branch_protection`

This commit provides changing the toggle to require signed commits on
branch protection.

The [API for signed commits](https://developer.github.com/v3/repos/branches/#get-required-signatures-of-protected-branch)
is separate endpoint from the branch protection url, and does not come on the same payload.
This means that we need to make an extra request to read and modify it.

This changes requires `go-github` at least v19.

Need:
 - [ ] Update `go-github` version: https://github.com/terraform-providers/terraform-provider-github/pull/207
 - [ ] Provide default required reviewers count to avoid GitHub update error: https://github.com/terraform-providers/terraform-provider-github/pull/211
Closes https://github.com/terraform-providers/terraform-provider-github/issues/87

* Include tests

* Adds documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature New feature or request Upstream
Projects
None yet
Milestone
No milestone
3 participants
@radeksimko @travispaul @majormoses