Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: checkout pull request via sha instead of ref #1043

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Conversation

jcudit
Copy link
Contributor

@jcudit jcudit commented Jan 21, 2022

Reconfigures the manual acceptance run Action to checkout using sha instead of ref.

@jcudit
Copy link
Contributor Author

jcudit commented Jan 21, 2022

Testing above shows this works, but is flaky. Good enough feedback for reviewing PRs without having to run tests locally, though!

@jcudit jcudit added this to the v4.20.0 milestone Jan 21, 2022
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: :shipit: :shipit:

@jcudit jcudit merged commit f9508c5 into main Jan 21, 2022
@jcudit jcudit deleted the test-manual-fixes branch January 21, 2022 22:14
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
kazaker pushed a commit to auto1-oss/terraform-provider-github that referenced this pull request Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants