Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment ID gets set incorrectly on update #1058

Merged
merged 3 commits into from
Mar 11, 2022

Conversation

aceresia-bg
Copy link
Contributor

The environment ID is updated in an incompatible way when updating the resource. Issue #1057

@kfcampbell kfcampbell added this to the v4.21.0 milestone Mar 3, 2022
@kfcampbell
Copy link
Member

@aceresia-bg I hope you don't mind, I've updated the PR to remove the now unnecessary import and I'll merge it now! Thanks for the contribution.

@kfcampbell kfcampbell merged commit 06c6fd7 into integrations:main Mar 11, 2022
kfcampbell added a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
* Update resource_github_repository_environment.go

* Update resource_github_repository_environment.go

* Remove now unnecessary strconv import

Co-authored-by: Keegan Campbell <kfcampbell@github.com>
kazaker pushed a commit to auto1-oss/terraform-provider-github that referenced this pull request Dec 28, 2022
* Update resource_github_repository_environment.go

* Update resource_github_repository_environment.go

* Remove now unnecessary strconv import

Co-authored-by: Keegan Campbell <kfcampbell@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants