Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding suspended_at attribute to github_user data source #1070

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

mattrobinsonsre
Copy link
Contributor

@mattrobinsonsre mattrobinsonsre commented Feb 17, 2022

Closes #978

Should be very low risk.

% go test -v ./... -run TestAccGithubUserDataSource
?   	github.com/terraform-providers/terraform-provider-github	[no test files]
=== RUN   TestAccGithubUserDataSource
=== RUN   TestAccGithubUserDataSource/queries_an_existing_individual_account_without_error
=== RUN   TestAccGithubUserDataSource/queries_an_existing_individual_account_without_error/with_an_anonymous_account
    data_source_github_user_test.go:40: anonymous account not supported for this operation
=== RUN   TestAccGithubUserDataSource/queries_an_existing_individual_account_without_error/with_an_individual_account
    testing.go:541: Acceptance tests skipped unless env 'TF_ACC' set
=== RUN   TestAccGithubUserDataSource/queries_an_existing_individual_account_without_error/with_an_organization_account
    testing.go:541: Acceptance tests skipped unless env 'TF_ACC' set
=== RUN   TestAccGithubUserDataSource/errors_when_querying_a_non-existing_individual_account
=== RUN   TestAccGithubUserDataSource/errors_when_querying_a_non-existing_individual_account/with_an_anonymous_account
    data_source_github_user_test.go:75: anonymous account not supported for this operation
=== RUN   TestAccGithubUserDataSource/errors_when_querying_a_non-existing_individual_account/with_an_individual_account
    testing.go:541: Acceptance tests skipped unless env 'TF_ACC' set
=== RUN   TestAccGithubUserDataSource/errors_when_querying_a_non-existing_individual_account/with_an_organization_account
    testing.go:541: Acceptance tests skipped unless env 'TF_ACC' set
--- PASS: TestAccGithubUserDataSource (0.00s)
    --- PASS: TestAccGithubUserDataSource/queries_an_existing_individual_account_without_error (0.00s)
        --- SKIP: TestAccGithubUserDataSource/queries_an_existing_individual_account_without_error/with_an_anonymous_account (0.00s)
        --- SKIP: TestAccGithubUserDataSource/queries_an_existing_individual_account_without_error/with_an_individual_account (0.00s)
        --- SKIP: TestAccGithubUserDataSource/queries_an_existing_individual_account_without_error/with_an_organization_account (0.00s)
    --- PASS: TestAccGithubUserDataSource/errors_when_querying_a_non-existing_individual_account (0.00s)
        --- SKIP: TestAccGithubUserDataSource/errors_when_querying_a_non-existing_individual_account/with_an_anonymous_account (0.00s)
        --- SKIP: TestAccGithubUserDataSource/errors_when_querying_a_non-existing_individual_account/with_an_individual_account (0.00s)
        --- SKIP: TestAccGithubUserDataSource/errors_when_querying_a_non-existing_individual_account/with_an_organization_account (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-github/github	(cached)

@kfcampbell kfcampbell added this to the v4.21.0 milestone Mar 3, 2022
@kfcampbell
Copy link
Member

Thanks for doing this!

@kfcampbell kfcampbell merged commit 66a4b90 into integrations:main Mar 11, 2022
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
kazaker pushed a commit to auto1-oss/terraform-provider-github that referenced this pull request Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return GitHub user suspended status (or some status/state)
2 participants