Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use pagination to fetch all team members #1092

Merged
merged 3 commits into from
Mar 25, 2022
Merged

fix: use pagination to fetch all team members #1092

merged 3 commits into from
Mar 25, 2022

Conversation

carocad
Copy link
Contributor

@carocad carocad commented Mar 17, 2022

If applied, this pull request will...

  • use pagination on the new github_team_members resource
  • compute a new etag based on the etag of each request

Why is this change needed?

  • Because it currently fetches only 30 members so terraform tries to change the members on each run even though nothing changed

References to relevant tickets, articles or other resources

@carocad @pascal-hofmann
chore: typo
bda6110 
Co-authored-by: Pascal Hofmann <mail@pascalhofmann.de>
@pascal-hofmann pascal-hofmann mentioned this pull request Mar 21, 2022
Closed
kfcampbell
kfcampbell approved these changes Mar 22, 2022
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you! I'll shoot to get this released at the end of this week.

@kfcampbell kfcampbell added this to the v4.23.0 milestone Mar 22, 2022
@kfcampbell kfcampbell merged commit fa02655 into integrations:main Mar 25, 2022
@carocad carocad deleted the fix/team_members branch March 26, 2022 11:24
kfcampbell added a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
@carocad @pascal-hofmann @kfcampbell
fix: use pagination to fetch all team members (integrations#1092)
96ea927 
* fix: use pagination to fetch all team members

* chore: typo

Co-authored-by: Pascal Hofmann <mail@pascalhofmann.de>

Co-authored-by: Camilo Roca <roc1fr@bosch.com>
Co-authored-by: Pascal Hofmann <mail@pascalhofmann.de>
Co-authored-by: Keegan Campbell <kfcampbell@github.com>
kazaker pushed a commit to auto1-oss/terraform-provider-github that referenced this pull request Dec 28, 2022
@carocad @pascal-hofmann @kfcampbell
fix: use pagination to fetch all team members (integrations#1092)
45570dd 
* fix: use pagination to fetch all team members

* chore: typo

Co-authored-by: Pascal Hofmann <mail@pascalhofmann.de>

Co-authored-by: Camilo Roca <roc1fr@bosch.com>
Co-authored-by: Pascal Hofmann <mail@pascalhofmann.de>
Co-authored-by: Keegan Campbell <kfcampbell@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascal-hofmann pascal-hofmann pascal-hofmann left review comments

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@carocad @pascal-hofmann @kfcampbell