Fixing github_repository_file owner/org handling
#1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passed, split it into `owner` and `repo`, use user as an `owner` otherwise Signed-off-by: Valery Masiutsin <val.masiutsin@gmail.com>
kfcampbell
reviewed
Jan 18, 2023
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
1 task
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
* Fixing `github_repository_file` owner handling, if `full_name` is passed, split it into `owner` and `repo`, use user as an `owner` otherwise Signed-off-by: Valery Masiutsin <val.masiutsin@gmail.com> * Update github/data_source_github_repository_file_test.go Co-authored-by: Keegan Campbell <me@kfcampbell.com> * Update website/docs/d/repository_file.html.markdown Co-authored-by: Keegan Campbell <me@kfcampbell.com> * Small docs fixup * Take into account @vmasutin's suggestion Signed-off-by: Valery Masiutsin <val.masiutsin@gmail.com> Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing
github_repository_fileowner handling, iffull_nameispassed, split it intoownerandrepo, use user as anownerotherwiseSigned-off-by: Valery Masiutsin val.masiutsin@gmail.com
Resolves #942
Behavior
Before the change?
orgAfter the change?
full_nameis passed then its being split intoorgandrepoOther information
Additional info
Pull request checklist
Does this introduce a breaking change?
No
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: BugType: FeatureType: DocumentationType: Maintenance