Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Schema Attribute Descriptions For Remaining Resources #1544

Merged
merged 4 commits into from
Feb 17, 2023
Merged

Add Schema Attribute Descriptions For Remaining Resources #1544

merged 4 commits into from
Feb 17, 2023

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Feb 13, 2023 •
edited
Loading

Resolves #1526

Behavior

Before the change?

  • Many resource attributes where missing their description in the resource schemas.

After the change?

  • Added attribute descriptions to the resource schemas.

Other information

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@X-Guardian
Copy link
Contributor Author

Hi @nickfloyd, this PR is ready for review.

kfcampbell
kfcampbell approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks a bunch!

@kfcampbell kfcampbell merged commit 8afbc19 into integrations:main Feb 17, 2023
reedloden pushed a commit to reedloden/terraform-provider-github that referenced this pull request Jun 14, 2023
@X-Guardian @kfcampbell @reedloden
Add Schema Attribute Descriptions For Remaining Resources (integratio…
7c9f21c 
…ns#1544)

* Add Schema Attribute Descriptions For Remaining Resources

* Description fixes.

---------

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
@X-Guardian @kfcampbell
Add Schema Attribute Descriptions For Remaining Resources (integratio…
cb37485 
…ns#1544)

* Add Schema Attribute Descriptions For Remaining Resources

* Description fixes.

---------

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS]: Many of the Resources are Missing Attribute Descriptions in their Schema
2 participants
@X-Guardian @kfcampbell