-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(github_branch_protection_v3): Add support for bypass_pull_request_allowances #1578
feat(github_branch_protection_v3): Add support for bypass_pull_request_allowances #1578
Conversation
…rovider-github into feat/github_branch_protection_v3_bypassers
@syakir-uzair do you have interest in picking this back up? The linting errors failing the bulid should be easy to resolve. |
…//github.com:/syakir-uzair/terraform-provider-github into feat/github_branch_protection_v3_bypassers
…//github.com:/syakir-uzair/terraform-provider-github into feat/github_branch_protection_v3_bypassers
@kfcampbell Sure, I have fixed the linting error |
I'd be grateful if a maintainer could look at this again. Support for pr bypassers is the only feature I am missing in order to replace github_branch_protection for github_branch_protection_v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing!
…t_allowances (integrations#1578) * feat(github_branch_protection_v3): Add support for bypass_pull_request_allowances * fix: Get bpra * chore: Remove debug * chore: Remove debug * fix: Lint * fix: Test * Test rename for convention --------- Co-authored-by: Nick Floyd <139819+nickfloyd@users.noreply.github.com> Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Resolves #1577
Behavior
Before the change?
github_branch_protection_v3
resourceAfter the change?
github_branch_protection_v3
resource by adding codes as written below:Other information
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking change
label)If
Yes
, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: Bug
Type: Feature
Type: Documentation
Type: Maintenance