Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make allows_public_repositories attribute on github_actions_runner_group modifiable #1705

Merged
merged 5 commits into from
Jun 1, 2023

Conversation

dbaur
Copy link
Contributor

@dbaur dbaur commented May 30, 2023

Resolves #1697


Behavior

Before the change?

After the change?

  • The allows_public_repositories attribute is now marked as Optional with the value defaulting to false (the same default value as described by the GitHub API)

Other information

  • The Acceptance tests for the github_actions_runner_group were not working. The selected_workflows test case references a) a file that does not exist and b) uses an invalid ref. I have updated the acceptance tests ensuring that the workflow file exists in the given repo and that the correct ref to the file is used.
  • One could think about updating the docs, as the ref in the current example is misleading

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@dbaur dbaur changed the title Allows public repositories Make allows_public_repositories attribute on github_actions_runner_group modifiable May 30, 2023
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could think about updating the docs, as the ref in the current example is misleading

Do you mind explaining a little more what you mean by this?

This PR looks great, thank you for contributing and improving the tests! The acceptance tests are passing for me locally.

@kfcampbell kfcampbell merged commit 0f4221f into integrations:main Jun 1, 2023
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
…oup modifiable (integrations#1705)

* fix merge conflict

* make allows_public_repositories settable as argument

* fix formatting

* added test, fixed test for selected_workflows

* fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Allow attribute allows_public_repositories on github_actions_runner_group to be set
3 participants