Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose SAML external identity exposed for GitHub user #1796

Merged
merged 14 commits into from
Aug 11, 2023
Merged

feat: expose SAML external identity exposed for GitHub user #1796

merged 14 commits into from
Aug 11, 2023

Conversation

felixlut
Copy link
Contributor

@felixlut felixlut commented Jul 14, 2023 •
edited
Loading

Continuation of #1794

This resource does essentially the same thing as #1778 (github_organization_external_identities), with the difference that this datasource fetches the external identity for one specific user, as opposed for every single user in the organization.

Behavior

This introduces a new datasource called github_user_external_identity which fetches the SAML/SCIM identity of a specific github user for the configured providers organization.

Other information

#1778 is very similar, with the difference that this PR is for a single user, while that one is for every user in the Organization. This change makes it so that both github_organization_external_identities and github_user_external_identity shares the same struct used to query the GraphQL API

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

  • Yes (Please add the Type: Breaking change label)
  • No

Pull request type

Feature

@felixlut felixlut mentioned this pull request Jul 14, 2023
Closed
1 task
@felixlut felixlut marked this pull request as ready for review July 31, 2023 19:55
@felixlut felixlut changed the title expose SAML external identity exposed for GitHub user feat: expose SAML external identity exposed for GitHub user Jul 31, 2023
kfcampbell
kfcampbell approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@kfcampbell kfcampbell merged commit 77cfacb into integrations:main Aug 11, 2023
o-sama pushed a commit to o-sama/terraform-provider-github that referenced this pull request Aug 19, 2023
@felixlut @kfcampbell @o-sama
feat: expose SAML external identity exposed for GitHub user (integrat…
cba2b73 
…ions#1796)

* create github_user_external_identity datasource

* add scim information and error handling for bad username org combo

* cleanup commentzs

* add docs for external identity

* move external identity to its own struct

* add variable to make referencing external identity easier

* add test

* add documentation

* remove old docs

* add docs reference in github.erb

---------

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
o-sama added a commit to o-sama/terraform-provider-github that referenced this pull request Aug 19, 2023
@o-sama
t # This is a combination of 27 commits.
ae35967 
Add docs, update tests, small changes to rulesets

octoherd: delete pull_request_template.md

feat: add pull_request_template.md PR template

feat: add data source to get organization members' SAML/SCIM linked identities (integrations#1778)

* add `github_organization_external_identities` which returns a list of github organization members and their SAML linked identity

* add docs

* add more fields to external_identities

* docs

---------

Co-authored-by: Keegan Campbell <me@kfcampbell.com>

fix: Github Environments Policy feature causing the provider to produce inconsistent result (integrations#1799)

* Add deployment policy resource

- Add the initial code to manage the resource
- Add sample configuration used to test it

TODO
- Documentation
- Tests

* Add schema description

* Fix creation of resource ID

* Add tests

* Add documentation

* Add terraform import support

* Undo example add

* Fix formatting

* PR feedback

* fix: environment branch policy failing to find the created resource

The `Read` operation of the Environments Branch Policy resource
was failing to find the newly created Branch policies, due to
wrongly encoded environment name. Which cause the provider to
be inconsistent.

This fix uses `url.PathEscape` instead of `url.QueryEscape`
since we are using path parameters with the Github API in
that case. Additionally 2 operations - `Read` and `Delete`
don't need to use it as they receive the environment name
already parsed and attempting to encode it again breaks the
name.

* Fix incorrect merge

---------

Co-authored-by: Massimiliano Donini <massimiliano.donini@gmail.com>
Co-authored-by: Keegan Campbell <me@kfcampbell.com>

Enforce valid chars in repo name (integrations#1806)

* Enforce valid chars in repo name

Signed-off-by: Benoit Donneaux <ben@tergology.com>

* Add dash to validate repo name

Signed-off-by: Benoit Donneaux <ben@tergology.com>

* Better name validation message

Signed-off-by: Benoit Donneaux <ben@tergology.com>

* Test repo name max length

Signed-off-by: Benoit Donneaux <ben@tergology.com>

* Test space in repo name

Signed-off-by: Benoit Donneaux <ben@tergology.com>

---------

Signed-off-by: Benoit Donneaux <ben@tergology.com>
Co-authored-by: Keegan Campbell <me@kfcampbell.com>

Use graphql rather than rest API for Github team membership (integrations#1786)

This change should provide better diffing for team membership for teams
with child teams. Currently, child team members are included in the parent
team's members list and so diffs are incorrect.

See [Issue 1193](integrations#1193).

feat: add immediate-response.yml auto responder workflow

build(deps): bump peter-evans/create-or-update-comment

Bumps [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment) from 6534843181fc2aeb7f9f1cd3cd4a7b956cada2db to 716151b9579b05352dbf244d48e968d211889bbc.
- [Release notes](https://github.com/peter-evans/create-or-update-comment/releases)
- [Commits](peter-evans/create-or-update-comment@6534843...716151b)

---
updated-dependencies:
- dependency-name: peter-evans/create-or-update-comment
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

Add Codespaces Organization Secret Repositories Resource.

Add depends_on to prevent branch policy being created before the corresponding environment (which results in an error), add more detail about the error thrown if deployment_branch_policy.custom_branch_policies is not set to true, tf fmt example

build(deps): bump peter-evans/create-or-update-comment (integrations#1830)

Bumps [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment) from 716151b9579b05352dbf244d48e968d211889bbc to 38217c6b94b54c0dbbe75be237257364e2dd2e62.
- [Release notes](https://github.com/peter-evans/create-or-update-comment/releases)
- [Commits](peter-evans/create-or-update-comment@716151b...38217c6)

---
updated-dependencies:
- dependency-name: peter-evans/create-or-update-comment
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

build(deps): bump golang.org/x/crypto from 0.11.0 to 0.12.0 (integrations#1829)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.11.0 to 0.12.0.
- [Commits](golang/crypto@v0.11.0...v0.12.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Keegan Campbell <me@kfcampbell.com>

build(deps): bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 (integrations#1828)

Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.10.0 to 0.11.0.
- [Commits](golang/oauth2@v0.10.0...v0.11.0)

---
updated-dependencies:
- dependency-name: golang.org/x/oauth2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

fix: `github_repository_collaborators` - mark `invitation_ids` as changed when new user invited (integrations#1825)

* fix: mark invitation_ids as changed if new user is invited

* fix: documentation

---------

Co-authored-by: Keegan Campbell <me@kfcampbell.com>

feat: expose SAML external identity exposed for GitHub user  (integrations#1796)

* create github_user_external_identity datasource

* add scim information and error handling for bad username org combo

* cleanup commentzs

* add docs for external identity

* move external identity to its own struct

* add variable to make referencing external identity easier

* add test

* add documentation

* remove old docs

* add docs reference in github.erb

---------

Co-authored-by: Keegan Campbell <me@kfcampbell.com>

Do not change squash_merge/merge_commit if it is not allowed in conf (integrations#1834)

Co-authored-by: Keegan Campbell <me@kfcampbell.com>

build(deps): bump peter-evans/create-or-update-comment

Bumps [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment) from 38217c6b94b54c0dbbe75be237257364e2dd2e62 to 5f22cb87da9514ab329de42e5462372dc19928a5.
- [Release notes](https://github.com/peter-evans/create-or-update-comment/releases)
- [Commits](peter-evans/create-or-update-comment@38217c6...5f22cb8)

---
updated-dependencies:
- dependency-name: peter-evans/create-or-update-comment
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

add primary_language to repository datasource

add primary_language to repository resource

add test to repository datasource

add docs for primary_language change

add test for resource

update name of testcase

run linting

update comment

Update to go-github v54
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
@felixlut @kfcampbell
feat: expose SAML external identity exposed for GitHub user (integrat…
fa3eb3b 
…ions#1796)

* create github_user_external_identity datasource

* add scim information and error handling for bad username org combo

* cleanup commentzs

* add docs for external identity

* move external identity to its own struct

* add variable to make referencing external identity easier

* add test

* add documentation

* remove old docs

* add docs reference in github.erb

---------

Co-authored-by: Keegan Campbell <me@kfcampbell.com>
@metebilgin metebilgin mentioned this pull request Mar 27, 2024
Closed
1 task
@3nassale7
Copy link

Continuation of #1794

This resource does essentially the same thing as #1778 (github_organization_external_identities), with the difference that this datasource fetches the external identity for one specific user, as opposed for every single user in the organization.

Behavior

This introduces a new datasource called github_user_external_identity which fetches the SAML/SCIM identity of a specific github user for the configured providers organization.

Other information

#1778 is very similar, with the difference that this PR is for a single user, while that one is for every user in the Organization. This change makes it so that both github_organization_external_identities and github_user_external_identity shares the same struct used to query the GraphQL API

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

  • Added the appropriate label for the given change

Does this introduce a breaking change?

  • Yes (Please add the Type: Breaking change label)

  • No

Pull request type

Feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixlut @3nassale7 @kfcampbell