Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in org rulesets.repository_id #1884

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

o-sama
Copy link
Contributor

@o-sama o-sama commented Sep 11, 2023


Before the change?

A typo was introduced when this feature was added in #1808.

  • Resource repository_organization_ruleset.conditions.repository_id has field inlcude.
  • Docs have the same typo.

After the change?

  • Typo fixed in both places.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

The breaking change is in the organization ruleset resource, a field name is being changed so users must reference the new name to move to the new version of the provider once this is released. @kfcampbell let me know if you'd like me to instead support two versions of the field, it's doable but in my opinion there hasn't been much time to adopt this feature and so we should release a patch instead. I'll be ready to add support for both either way.

@o-sama
Copy link
Contributor Author

o-sama commented Sep 11, 2023

BTW, @kfcampbell, if we do release a patch as is and break the use of inlcude, would it be feasible to do so as quick as possible to avoid more people using the version with the typo? Again, my bad on this one, I missed it when working on the feature.

Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the correction here. We'll drop a major version.

@nickfloyd nickfloyd merged commit b92c841 into integrations:main Sep 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants