Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: Get the license for a repository #2026

Merged
merged 9 commits into from
Jan 5, 2024
Merged

[FEAT]: Get the license for a repository #2026

merged 9 commits into from
Jan 5, 2024

Conversation

Nmishin
Copy link
Contributor

@Nmishin Nmishin commented Nov 22, 2023 •
edited
Loading

Resolves #2022

Before the change?

After the change?

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@Nmishin Nmishin marked this pull request as draft November 23, 2023 11:49
@Nmishin Nmishin marked this pull request as ready for review December 6, 2023 22:04
kfcampbell
kfcampbell reviewed Jan 5, 2024
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you! I have one small request: can we rename repositorylicense to repository_license to better fit our schema patterns?

kfcampbell
kfcampbell approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! Confirming integration tests are passing for me. I'll get this merged and released shortly.

@kfcampbell kfcampbell merged commit 55c1188 into integrations:main Jan 5, 2024
3 checks passed
@oprudkyi oprudkyi mentioned this pull request Jan 11, 2024
Closed
1 task
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
@Nmishin @nickfloyd @kfcampbell
[FEAT]: Get the license for a repository (integrations#2026)
a304997 
* [FEAT]: Get the license for a repository

* Remove unneeded option

* Update documentation for repository license

* Add test for license

* Fix test for github repository license

* Bump go-github from v52 to v55 in the resource_github_issue_labels

* Rename repositorylicense to repository_license

---------

Co-authored-by: Nick Floyd <139819+nickfloyd@users.noreply.github.com>
Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcampbell kfcampbell kfcampbell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: Get the license for a repository
3 participants
@Nmishin @kfcampbell @nickfloyd