-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add github_enterprise_actions_runner_group
#2158
Conversation
add github_enterprise_actions_runner_group
github_enterprise_actions_runner_group
d00ba49
to
5a67e73
Compare
5a67e73
to
39987f5
Compare
@bradam12, thanks for your work here. My team could really use this feature. Looking forward to seeing it merged and deployed. |
@bradam12, what's the status of this PR? Is there anything left to do or can I tag a maintainer for a final review? Have these changes been tested on your Enterprise account? |
Nothing left on my end. I've tested this in our GHES. |
@kfcampbell, can you review/approve/merge/deploy this when you have some time? |
I'd love to get this out soon. Is there anything else you need from me @kfcampbell? |
No, I'll get this released shortly. Thank you for your patience. |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github](https://registry.terraform.io/providers/integrations/github) ([source](https://github.com/integrations/terraform-provider-github)) | required_provider | minor | `6.0.1` -> `6.2.0` | --- ### Release Notes <details> <summary>integrations/terraform-provider-github (github)</summary> ### [`v6.2.0`](https://github.com/integrations/terraform-provider-github/releases/tag/v6.2.0) [Compare Source](https://github.com/integrations/terraform-provider-github/compare/v6.1.0...v6.2.0) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### Features - feat: add `github_enterprise_actions_runner_group` by [@​bradam12](https://github.com/bradam12) in [https://github.com/integrations/terraform-provider-github/pull/2158](https://github.com/integrations/terraform-provider-github/pull/2158) - Feat: Fixes abandoned PR [#​2017](https://github.com/integrations/terraform-provider-github/issues/2017): Add support for the require_last_push_approval flag in github_branch_protection_v3 by [@​georgekaz](https://github.com/georgekaz) in [https://github.com/integrations/terraform-provider-github/pull/2199](https://github.com/integrations/terraform-provider-github/pull/2199) ##### Bugfixes - fix(data_source_github_rest_api): just read body and convert bytes into string by [@​riezebosch](https://github.com/riezebosch) in [https://github.com/integrations/terraform-provider-github/pull/2152](https://github.com/integrations/terraform-provider-github/pull/2152) ##### 🛠️ Maintenance - build(deps): bump golang.org/x/oauth2 from 0.17.0 to 0.18.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2189](https://github.com/integrations/terraform-provider-github/pull/2189) - build(deps): bump google.golang.org/protobuf from 1.32.0 to 1.33.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2194](https://github.com/integrations/terraform-provider-github/pull/2194) **Full Changelog**: integrations/terraform-provider-github@v6.1.0...v6.2.0 ### [`v6.1.0`](https://github.com/integrations/terraform-provider-github/releases/tag/v6.1.0) [Compare Source](https://github.com/integrations/terraform-provider-github/compare/v6.0.1...v6.1.0) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed - fix: validation rule for `results_per_page` of `github_repositories` data source by [@​dschniepp](https://github.com/dschniepp) in [https://github.com/integrations/terraform-provider-github/pull/2185](https://github.com/integrations/terraform-provider-github/pull/2185) - fix: Prevent loading of allowed actions if not configured by [@​Danielku15](https://github.com/Danielku15) in [https://github.com/integrations/terraform-provider-github/pull/2186](https://github.com/integrations/terraform-provider-github/pull/2186) - fix(data_source_github_rest_api): only allow for 404 on err by [@​riezebosch](https://github.com/riezebosch) in [https://github.com/integrations/terraform-provider-github/pull/2154](https://github.com/integrations/terraform-provider-github/pull/2154) - fix: error if autolink reference not found by [@​bradam12](https://github.com/bradam12) in [https://github.com/integrations/terraform-provider-github/pull/2164](https://github.com/integrations/terraform-provider-github/pull/2164) - feat: Add `github_actions_enterprise_permissions` by [@​ErikElkins](https://github.com/ErikElkins) in [https://github.com/integrations/terraform-provider-github/pull/2155](https://github.com/integrations/terraform-provider-github/pull/2155) - docs: configure release notes categories based on labels by [@​laughedelic](https://github.com/laughedelic) in [https://github.com/integrations/terraform-provider-github/pull/2184](https://github.com/integrations/terraform-provider-github/pull/2184) #### New Contributors - [@​dschniepp](https://github.com/dschniepp) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/2185](https://github.com/integrations/terraform-provider-github/pull/2185) - [@​riezebosch](https://github.com/riezebosch) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/2154](https://github.com/integrations/terraform-provider-github/pull/2154) - [@​bradam12](https://github.com/bradam12) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/2164](https://github.com/integrations/terraform-provider-github/pull/2164) - [@​ErikElkins](https://github.com/ErikElkins) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/2155](https://github.com/integrations/terraform-provider-github/pull/2155) - [@​laughedelic](https://github.com/laughedelic) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/2184](https://github.com/integrations/terraform-provider-github/pull/2184) **Full Changelog**: integrations/terraform-provider-github@v6.0.1...v6.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjI1Ny4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
Resolves #1482
This adds a new resource
github_enterprise_actions_runner_group
to control runner groups at the enterprise level.Additional attribute
database_id
added todata.github_enterprise
andresource.github_enterprise_organization
.The
id
fields on these two items are the node ID used for v4, and the "traditional" ID is exposed via DatabaseId. Other items usenode_id
andid
, but I didn't want to introduce a breaking change so I just added as new attributes.Tests are added and running successfully. I set the following env vars:
GITHUB_ORGANIZATION
,GITHUB_BASE_URL
,GITHUB_TOKEN
,ENTERPRISE_ACCOUNT
,ENTERPRISE_SLUG
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!