Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation rule for results_per_page of github_repositories data source #2185

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

dschniepp
Copy link
Contributor

@dschniepp dschniepp commented Mar 6, 2024

Resolves #2172


Before the change?

  • results_per_page validation validates a range between 1 and 100.

After the change?

  • results_per_page validation validates a range between 1 and 1000. As described by the underlaying API.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@kfcampbell kfcampbell merged commit a69c6f0 into integrations:main Mar 7, 2024
4 checks passed
kireque referenced this pull request in kireque/home-ops Mar 22, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github](https://registry.terraform.io/providers/integrations/github)
([source](https://github.com/integrations/terraform-provider-github))
| required_provider | minor | `6.0.1` -> `6.2.0` |

---

### Release Notes

<details>
<summary>integrations/terraform-provider-github (github)</summary>

###
[`v6.2.0`](https://github.com/integrations/terraform-provider-github/releases/tag/v6.2.0)

[Compare
Source](https://github.com/integrations/terraform-provider-github/compare/v6.1.0...v6.2.0)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

##### Features

- feat: add `github_enterprise_actions_runner_group` by
[@&#8203;bradam12](https://github.com/bradam12) in
[https://github.com/integrations/terraform-provider-github/pull/2158](https://github.com/integrations/terraform-provider-github/pull/2158)
- Feat: Fixes abandoned PR
[#&#8203;2017](https://github.com/integrations/terraform-provider-github/issues/2017):
Add support for the require_last_push_approval flag in
github_branch_protection_v3 by
[@&#8203;georgekaz](https://github.com/georgekaz) in
[https://github.com/integrations/terraform-provider-github/pull/2199](https://github.com/integrations/terraform-provider-github/pull/2199)

##### Bugfixes

- fix(data_source_github_rest_api): just read body and convert bytes
into string by [@&#8203;riezebosch](https://github.com/riezebosch) in
[https://github.com/integrations/terraform-provider-github/pull/2152](https://github.com/integrations/terraform-provider-github/pull/2152)

##### 🛠️ Maintenance

- build(deps): bump golang.org/x/oauth2 from 0.17.0 to 0.18.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/integrations/terraform-provider-github/pull/2189](https://github.com/integrations/terraform-provider-github/pull/2189)
- build(deps): bump google.golang.org/protobuf from 1.32.0 to 1.33.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/integrations/terraform-provider-github/pull/2194](https://github.com/integrations/terraform-provider-github/pull/2194)

**Full Changelog**:
integrations/terraform-provider-github@v6.1.0...v6.2.0

###
[`v6.1.0`](https://github.com/integrations/terraform-provider-github/releases/tag/v6.1.0)

[Compare
Source](https://github.com/integrations/terraform-provider-github/compare/v6.0.1...v6.1.0)

<!-- Release notes generated using configuration in .github/release.yml
at main -->

#### What's Changed

- fix: validation rule for `results_per_page` of `github_repositories`
data source by [@&#8203;dschniepp](https://github.com/dschniepp) in
[https://github.com/integrations/terraform-provider-github/pull/2185](https://github.com/integrations/terraform-provider-github/pull/2185)
- fix: Prevent loading of allowed actions if not configured by
[@&#8203;Danielku15](https://github.com/Danielku15) in
[https://github.com/integrations/terraform-provider-github/pull/2186](https://github.com/integrations/terraform-provider-github/pull/2186)
- fix(data_source_github_rest_api): only allow for 404 on err by
[@&#8203;riezebosch](https://github.com/riezebosch) in
[https://github.com/integrations/terraform-provider-github/pull/2154](https://github.com/integrations/terraform-provider-github/pull/2154)
- fix: error if autolink reference not found by
[@&#8203;bradam12](https://github.com/bradam12) in
[https://github.com/integrations/terraform-provider-github/pull/2164](https://github.com/integrations/terraform-provider-github/pull/2164)
- feat: Add `github_actions_enterprise_permissions` by
[@&#8203;ErikElkins](https://github.com/ErikElkins) in
[https://github.com/integrations/terraform-provider-github/pull/2155](https://github.com/integrations/terraform-provider-github/pull/2155)
- docs: configure release notes categories based on labels by
[@&#8203;laughedelic](https://github.com/laughedelic) in
[https://github.com/integrations/terraform-provider-github/pull/2184](https://github.com/integrations/terraform-provider-github/pull/2184)

#### New Contributors

- [@&#8203;dschniepp](https://github.com/dschniepp) made their first
contribution in
[https://github.com/integrations/terraform-provider-github/pull/2185](https://github.com/integrations/terraform-provider-github/pull/2185)
- [@&#8203;riezebosch](https://github.com/riezebosch) made their first
contribution in
[https://github.com/integrations/terraform-provider-github/pull/2154](https://github.com/integrations/terraform-provider-github/pull/2154)
- [@&#8203;bradam12](https://github.com/bradam12) made their first
contribution in
[https://github.com/integrations/terraform-provider-github/pull/2164](https://github.com/integrations/terraform-provider-github/pull/2164)
- [@&#8203;ErikElkins](https://github.com/ErikElkins) made their first
contribution in
[https://github.com/integrations/terraform-provider-github/pull/2155](https://github.com/integrations/terraform-provider-github/pull/2155)
- [@&#8203;laughedelic](https://github.com/laughedelic) made their
first contribution in
[https://github.com/integrations/terraform-provider-github/pull/2184](https://github.com/integrations/terraform-provider-github/pull/2184)

**Full Changelog**:
integrations/terraform-provider-github@v6.0.1...v6.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjI1Ny4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Validation prevents valid results_per_page setting
2 participants