chore(actions_runner_group): fix missing schema id #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm running into this issue now. Tested this PR locally and can confirm it fixes the issue and tests pass. |
bradam12
approved these changes
Mar 20, 2024
|
@kfcampbell hello! Can you please review and release if it is from your side? |
|
@kfcampbell any update on this? |
kfcampbell
approved these changes
Mar 25, 2024
kireque
referenced
this pull request
in kireque/home-ops
Mar 28, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github](https://registry.terraform.io/providers/integrations/github) ([source](https://github.com/integrations/terraform-provider-github)) | required_provider | patch | `6.2.0` -> `6.2.1` | --- ### Release Notes <details> <summary>integrations/terraform-provider-github (github)</summary> ### [`v6.2.1`](https://github.com/integrations/terraform-provider-github/releases/tag/v6.2.1) [Compare Source](https://github.com/integrations/terraform-provider-github/compare/v6.2.0...v6.2.1) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### 🐛 Bugfixes - chore(actions_runner_group): fix missing schema id by [@​EttoreFoti](https://github.com/EttoreFoti) in [https://github.com/integrations/terraform-provider-github/pull/2195](https://github.com/integrations/terraform-provider-github/pull/2195) - chore(organization_webhook): fix insecure_ssl by [@​EttoreFoti](https://github.com/EttoreFoti) in [https://github.com/integrations/terraform-provider-github/pull/2196](https://github.com/integrations/terraform-provider-github/pull/2196) ##### 🛠️ Maintenance - build(deps): bump actions/add-to-project from 0.6.0 to 0.6.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2210](https://github.com/integrations/terraform-provider-github/pull/2210) - build(deps): bump github.com/golangci/golangci-lint from 1.56.2 to 1.57.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/integrations/terraform-provider-github/pull/2209](https://github.com/integrations/terraform-provider-github/pull/2209) #### New Contributors - [@​EttoreFoti](https://github.com/EttoreFoti) made their first contribution in [https://github.com/integrations/terraform-provider-github/pull/2195](https://github.com/integrations/terraform-provider-github/pull/2195) **Full Changelog**: integrations/terraform-provider-github@v6.2.0...v6.2.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNzEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI3MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2162
Before the change?
The provider would fail to create
github_actions_runner_groupdue to broken schema, it would create the resource but causes terraform to fail.After the change?
The provider correctly creates the broken resource.
Pull request checklist
Both checks are not needed as the functionality as not been changed.
TF Acceptance Test output
❯ TF_ACC=1 go test -v ./... -run ^TestAccGithubActionsRunnerGroup ? github.com/integrations/terraform-provider-github/v6 [no test files] === RUN TestAccGithubActionsRunnerGroup === RUN TestAccGithubActionsRunnerGroup/creates_runner_groups_without_error === RUN TestAccGithubActionsRunnerGroup/creates_runner_groups_without_error/with_an_anonymous_account resource_github_actions_runner_group_test.go:118: anonymous account not supported for this operation === RUN TestAccGithubActionsRunnerGroup/creates_runner_groups_without_error/with_an_individual_account resource_github_actions_runner_group_test.go:122: individual account not supported for this operation === RUN TestAccGithubActionsRunnerGroup/creates_runner_groups_without_error/with_an_organization_account === RUN TestAccGithubActionsRunnerGroup/manages_runner_visibility === RUN TestAccGithubActionsRunnerGroup/manages_runner_visibility/with_an_anonymous_account resource_github_actions_runner_group_test.go:182: anonymous account not supported for this operation === RUN TestAccGithubActionsRunnerGroup/manages_runner_visibility/with_an_individual_account resource_github_actions_runner_group_test.go:186: individual account not supported for this operation === RUN TestAccGithubActionsRunnerGroup/manages_runner_visibility/with_an_organization_account === RUN TestAccGithubActionsRunnerGroup/imports_an_all_runner_group_without_error === RUN TestAccGithubActionsRunnerGroup/imports_an_all_runner_group_without_error/with_an_anonymous_account resource_github_actions_runner_group_test.go:233: anonymous account not supported for this operation === RUN TestAccGithubActionsRunnerGroup/imports_an_all_runner_group_without_error/with_an_individual_account resource_github_actions_runner_group_test.go:237: individual account not supported for this operation === RUN TestAccGithubActionsRunnerGroup/imports_an_all_runner_group_without_error/with_an_organization_account === RUN TestAccGithubActionsRunnerGroup/imports_a_private_runner_group_without_error === RUN TestAccGithubActionsRunnerGroup/imports_a_private_runner_group_without_error/with_an_anonymous_account resource_github_actions_runner_group_test.go:283: anonymous account not supported for this operation === RUN TestAccGithubActionsRunnerGroup/imports_a_private_runner_group_without_error/with_an_individual_account resource_github_actions_runner_group_test.go:287: individual account not supported for this operation === RUN TestAccGithubActionsRunnerGroup/imports_a_private_runner_group_without_error/with_an_organization_account resource_github_actions_runner_group_test.go:294: always shows a diff for visibility 'all' => 'private' === RUN TestAccGithubActionsRunnerGroup/imports_a_selected_runner_group_without_error === RUN TestAccGithubActionsRunnerGroup/imports_a_selected_runner_group_without_error/with_an_individual_account provider_utils.go:64: GITHUB_TOKEN and GITHUB_OWNER environment variables should be set provider_utils.go:74: Skipping TestAccGithubActionsRunnerGroup/imports_a_selected_runner_group_without_error/with_an_individual_account which requires individual mode === RUN TestAccGithubActionsRunnerGroup/imports_a_selected_runner_group_without_error/with_an_organization_account --- PASS: TestAccGithubActionsRunnerGroup (94.77s) --- PASS: TestAccGithubActionsRunnerGroup/creates_runner_groups_without_error (33.11s) --- SKIP: TestAccGithubActionsRunnerGroup/creates_runner_groups_without_error/with_an_anonymous_account (0.00s) --- SKIP: TestAccGithubActionsRunnerGroup/creates_runner_groups_without_error/with_an_individual_account (0.00s) --- PASS: TestAccGithubActionsRunnerGroup/creates_runner_groups_without_error/with_an_organization_account (33.11s) --- PASS: TestAccGithubActionsRunnerGroup/manages_runner_visibility (18.40s) --- SKIP: TestAccGithubActionsRunnerGroup/manages_runner_visibility/with_an_anonymous_account (0.00s) --- SKIP: TestAccGithubActionsRunnerGroup/manages_runner_visibility/with_an_individual_account (0.00s) --- PASS: TestAccGithubActionsRunnerGroup/manages_runner_visibility/with_an_organization_account (18.40s) --- PASS: TestAccGithubActionsRunnerGroup/imports_an_all_runner_group_without_error (21.62s) --- SKIP: TestAccGithubActionsRunnerGroup/imports_an_all_runner_group_without_error/with_an_anonymous_account (0.00s) --- SKIP: TestAccGithubActionsRunnerGroup/imports_an_all_runner_group_without_error/with_an_individual_account (0.00s) --- PASS: TestAccGithubActionsRunnerGroup/imports_an_all_runner_group_without_error/with_an_organization_account (21.62s) --- PASS: TestAccGithubActionsRunnerGroup/imports_a_private_runner_group_without_error (0.00s) --- SKIP: TestAccGithubActionsRunnerGroup/imports_a_private_runner_group_without_error/with_an_anonymous_account (0.00s) --- SKIP: TestAccGithubActionsRunnerGroup/imports_a_private_runner_group_without_error/with_an_individual_account (0.00s) --- SKIP: TestAccGithubActionsRunnerGroup/imports_a_private_runner_group_without_error/with_an_organization_account (0.00s) --- PASS: TestAccGithubActionsRunnerGroup/imports_a_selected_runner_group_without_error (21.64s) --- SKIP: TestAccGithubActionsRunnerGroup/imports_a_selected_runner_group_without_error/with_an_individual_account (0.00s) --- PASS: TestAccGithubActionsRunnerGroup/imports_a_selected_runner_group_without_error/with_an_organization_account (21.64s) PASS ok github.com/integrations/terraform-provider-github/v6/github 95.202sDoes this introduce a breaking change?
Please see our docs on breaking changes to help!