-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 5.43 upgrade signoff #2222
Open
bzarboni1
wants to merge
8
commits into
integrations:main
Choose a base branch
from
FociSolutions:fix-5.43-upgrade-signoff
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix 5.43 upgrade signoff #2222
bzarboni1
wants to merge
8
commits into
integrations:main
from
FociSolutions:fix-5.43-upgrade-signoff
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerMizuyabu
force-pushed
the
fix-5.43-upgrade-signoff
branch
from
April 9, 2024 13:59
7c379b7
to
b8f15a9
Compare
* fix: 5.43 upgrade signoff --------- Co-authored-by: Ben Zarboni <ben.zarboni@focisolutions.com>
Thanks for the contribution! The newly-added test is failing for me:
with the following error:
Is this something you can reproduce? |
Apologies for the late reply. |
Bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #I2077
Before the change?
repository
update, there's a bug in the GitHub 2022-11-28 version, that throws a 422 error whenever theweb_commit_signoff_required
is set to true, even when it is already true.After the change?
web_commit_signoff_required
has been modified. If it has, it is passed along in the request. If it hasn't, it is silently dropped from the request.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!