Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resource_github_actions_environment_secret): handle 404 on repo read #2323

Merged
merged 3 commits into from
Oct 7, 2024
Merged

fix(resource_github_actions_environment_secret): handle 404 on repo read #2323

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef6efa1
fix(resource_github_actions_environment_secret): handle 404 on repo read
scootafew Jul 18, 2024
0ec5d5c
Merge branch 'main' into fix/resource_github_actions_environment_secret
nickfloyd Aug 19, 2024
68c3c2d
Merge branch 'main' into fix/resource_github_actions_environment_secret
kfcampbell Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions github/resource_github_actions_environment_secret.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,14 @@ func resourceGithubActionsEnvironmentSecretRead(d *schema.ResourceData, meta int

repo, _, err := client.Repositories.Get(ctx, owner, repoName)
if err != nil {
if ghErr, ok := err.(*github.ErrorResponse); ok {
if ghErr.Response.StatusCode == http.StatusNotFound {
log.Printf("[INFO] Removing environment secret %s from state because it no longer exists in GitHub",
d.Id())
d.SetId("")
return nil
}
}
return err
}

Expand Down
Loading