Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add github_user_ssh_signing_key #2366

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: add github_user_ssh_signing_key #2366

wants to merge 4 commits into from

Conversation

simonostendorf
Copy link

Resolves #2365

Before the change?

  • managing ssh signing keys was not possible

After the change?

  • managing ssh signing keys is possible with github_user_ssh_signing_key resource
  • the resource is equal to the existing github_user_ssh_key resource that manages ssh auth keys

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@kfcampbell
Copy link
Member

@simonostendorf can you please link to the new doc you created in the github.erb file so it's discoverable?

@simonostendorf
Copy link
Author

@simonostendorf can you please link to the new doc you created in the github.erb file so it's discoverable?

@kfcampbell sorry forgot that. I added it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add difference of auth and signing keys to github_user_ssh_key
2 participants
@simonostendorf @kfcampbell