Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GetTeamBySlug instead of ListTeams in team data source #579

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

k24dizzle
Copy link
Contributor

Instead of using ListTeams to iterate through every single team, use GetTeamBySlug to find the team that matches a given slug.

@ghost ghost added the size/XS label Oct 27, 2020
@k24dizzle
Copy link
Contributor Author

New to contributing to this repo, so forgive me if this info is located somewhere.

I see the acceptance tests are failing on this PR, but I was hoping to just run the tests related to this file (data_source_github_team_test.go) locally.

Is there an easy way to just test my changes without triggering the entire acceptance test suite locally as well?

@jcudit jcudit added this to the v4.0.0 milestone Nov 5, 2020
@jcudit
Copy link
Contributor

jcudit commented Nov 5, 2020

@k24dizzle thanks for putting this PR together. The change looks 👌 but will do some extra validation outside of this PR to make sure all is well.

Apologies for the state of acceptance testing. I'll have to do more reading up on why this behaviour is happening. Seems to be an issue with forks and the workflows configured for this project 🙃 . As for local testing, take a look at the CONTRIBUTING.md that was recently merged.

I will also get another branch started that pulls in the commits in this PR, which should get the test suite running properly against this diff.

@jcudit jcudit modified the milestones: v4.0.0, v4.0.1 Nov 5, 2020
Copy link
Contributor

@jcudit jcudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tested well over here. Will follow up with a PR that adds the latest testing suite to this resource.

@jcudit jcudit merged commit 2c140a9 into integrations:master Nov 13, 2020
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants