Modify github_team_repository to accept slug as a valid team_id as well

[k24dizzle]

Attempt to address: #675

Was tested locally, and I attempted to modify the acceptance tests to test this new behavior.

However, I wasn't able to get the acceptance tests to run locally, even after creating a new org called kzhaotest and setting the GITHUB_TOKEN and GITHUB_ORGANIZATION env variables:

kzhao@kzhao-mbp151 ~/go/src/github.com/k24dizzle/terraform-provider-github (teamid) $ TF_LOG=DEBUG TF_ACC=1  go test -v   ./... -run ^TestAccGithubTeamRepository_basic
?   	github.com/terraform-providers/terraform-provider-github	[no test files]
=== RUN   TestAccGithubTeamRepository_basic
2021/02/04 16:18:07 [ERROR] Github API Request error: &http.badStringError{what:"unsupported protocol scheme", str:""}
2021/02/04 16:18:07 [TRACE] Acquiring lock for GitHub API request (%!q(<nil>))
2021/02/04 16:18:07 [TRACE] Releasing lock for GitHub API request (%!q(<nil>))
    TestAccGithubTeamRepository_basic: resource_github_team_repository_test.go:17: Skipping because GITHUB_OWNER "kzhaotest" is a user, not an organization.
--- SKIP: TestAccGithubTeamRepository_basic (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-github/github	(cached)

Open to any feedback/comments

[jcudit]

Looks good! Had one question but seems safe to 🚢

This resource had not gotten it's tests updated to work with the latest test suite. Please cherry-pick a122f31 to get tests passing.

[jcudit]

This seems like the riskiest bit. What was your experience leading up to this diff?

[k24dizzle]

In my testing, I didn't have this if statement at first.

I tried setting the team_id to be a team slug, and was able to plan and apply the following config to create a new team repo connection:

resource "github_team_repository" "test" {
    team_id = "sampleteam"
    repository = "testteamrepo"
    permission = "push"
}

When I tried another plan after that I expected that terraform would say that there would be no changes necessary. However, I got the following output:

Terraform will perform the following actions:

  # github_team_repository.test must be replaced
-/+ resource "github_team_repository" "test" {
      ~ etag       = "W/\"6469d39bbad910892556bd4bb130c23ab7ffb655ec6a312d592f2e76736d67c9\"" -> (known after apply)
      ~ id         = "4466024:testteamrepo" -> (known after apply)
        permission = "push"
        repository = "testteamrepo"
      ~ team_id    = "4466024" -> "123" # forces replacement
    }

Plan: 1 to add, 0 to change, 1 to destroy.

When terraform refreshed the state, using this resourceGithubTeamRepositoryRead function, it would replace the team_id from a slug to the actual team id, making it think that it would need to replace this resource.

So I added this if statement to avoid this situation. We want to make sure that the team_id field remains whatever the user set initially. The only situation I could think of where we would want to actually set this team_id field here, would be when we were importing a team_repo resource, in which we would want to populate this field for the user.

[jcudit]

Appreciate the detail here, thanks.

[k24dizzle]

Also thanks for updating the tests! That helps a lot! I went ahead and cherry-picked your commit into this PR