Fix update default branch #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Special-casing "main" in the previous version of this code meant that it was impossible to change the default branch to "main" from something else (e.g. "master").
jcudit
approved these changes
Mar 16, 2021
k24dizzle
pushed a commit
to lyft/terraform-provider-github
that referenced
this pull request
Mar 16, 2021
* Test changing default_branch from/to main * Fix updating default_branch on github_repository Special-casing "main" in the previous version of this code meant that it was impossible to change the default branch to "main" from something else (e.g. "master").
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
* Test changing default_branch from/to main * Fix updating default_branch on github_repository Special-casing "main" in the previous version of this code meant that it was impossible to change the default branch to "main" from something else (e.g. "master").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the logic for when changes to
default_branchongithub_repositoryshould be applied (for those that haven't upgraded togithub_default_branchyet).Closes #715