Give a helpful error message when trying to import a github_branch that does not exist #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- check importing a branch that exists - check error message when importing a branch that does not exist
There was no error message if the branch the user was trying to import
did not exist on GitHub, so the user got the default terraform error:
Error: nil entry in ImportState results. This is always a bug with
the resource that is being imported. Please report this as
a bug to Terraform.
The new error message is:
Error: Repository tftest does not have a branch named nosuchbranch.
jcudit
approved these changes
Mar 24, 2021
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
…at does not exist (integrations#734) * Add tests for importing github_branch - check importing a branch that exists - check error message when importing a branch that does not exist * Add error message for importing github_branch There was no error message if the branch the user was trying to import did not exist on GitHub, so the user got the default terraform error: Error: nil entry in ImportState results. This is always a bug with the resource that is being imported. Please report this as a bug to Terraform. The new error message is: Error: Repository tftest does not have a branch named nosuchbranch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in issue #636, errors are not reported properly when importing a
github_branchresource. In particular, the case where the branch does not exist on GitHub is not handled by the provider and the user gets a Terraform error instead:I've updated this message to: