Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing.md local development and environment setup tweaks #752

Merged
merged 6 commits into from
Apr 6, 2021

Conversation

kfcampbell
Copy link
Member

@kfcampbell kfcampbell commented Apr 3, 2021

When working on #746 I took a couple of notes on things I needed to get set up to develop on the project. I'm hopeful that this is helpful to others who may want to contribute to the project!

👀 Full rendered doc 👀
👀 Rendered rich diff 👀

@kfcampbell kfcampbell changed the title Initial commit of contributing.md updates Contributing.md local development and environment setup tweaks Apr 3, 2021
Copy link
Contributor

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, thanks so much @kfcampbell! Just some tiny changes to the wording and expanding the [here] links so it's easier to follow.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
kfcampbell and others added 5 commits April 6, 2021 09:33
Co-authored-by: Issy Long <issyl0@github.com>
Co-authored-by: Issy Long <issyl0@github.com>
Co-authored-by: Issy Long <issyl0@github.com>
Co-authored-by: Issy Long <issyl0@github.com>
Co-authored-by: Issy Long <issyl0@github.com>
@kfcampbell
Copy link
Member Author

@issyl0 thanks for the suggestions! I've committed them all.

Copy link
Contributor

@jcudit jcudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for capturing all of this! Excited to see the contributions that this will enable over time 🙇🏾

@jcudit jcudit added this to the v4.7.0 milestone Apr 6, 2021
@jcudit jcudit merged commit 9e571a9 into integrations:master Apr 6, 2021
@kfcampbell kfcampbell deleted the contributing-tweaks branch April 6, 2021 22:58
dependabot bot added a commit to k24dizzle/terraform-provider-github that referenced this pull request Jan 19, 2022
…rations#752)

* Initial commit of contributing.md updates

* Update CONTRIBUTING.md

Co-authored-by: Issy Long <issyl0@github.com>

* Update CONTRIBUTING.md

Co-authored-by: Issy Long <issyl0@github.com>

* Update CONTRIBUTING.md

Co-authored-by: Issy Long <issyl0@github.com>

* Update CONTRIBUTING.md

Co-authored-by: Issy Long <issyl0@github.com>

* Update CONTRIBUTING.md

Co-authored-by: Issy Long <issyl0@github.com>

Co-authored-by: Issy Long <issyl0@github.com>
dependabot bot added a commit to k24dizzle/terraform-provider-github that referenced this pull request Jan 19, 2022
…rations#752)

* Initial commit of contributing.md updates

* Update CONTRIBUTING.md

Co-authored-by: Issy Long <issyl0@github.com>

* Update CONTRIBUTING.md

Co-authored-by: Issy Long <issyl0@github.com>

* Update CONTRIBUTING.md

Co-authored-by: Issy Long <issyl0@github.com>

* Update CONTRIBUTING.md

Co-authored-by: Issy Long <issyl0@github.com>

* Update CONTRIBUTING.md

Co-authored-by: Issy Long <issyl0@github.com>

Co-authored-by: Issy Long <issyl0@github.com>
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
…rations#752)

* Initial commit of contributing.md updates

* Update CONTRIBUTING.md

Co-authored-by: Issy Long <issyl0@github.com>

* Update CONTRIBUTING.md

Co-authored-by: Issy Long <issyl0@github.com>

* Update CONTRIBUTING.md

Co-authored-by: Issy Long <issyl0@github.com>

* Update CONTRIBUTING.md

Co-authored-by: Issy Long <issyl0@github.com>

* Update CONTRIBUTING.md

Co-authored-by: Issy Long <issyl0@github.com>

Co-authored-by: Issy Long <issyl0@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants