fix(data/repository): set name and full_name attributes as computed #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann-soubeyrand
force-pushed
the
data-repository-computed-fields
branch
from
312ede7 to
d100a5f
Compare
|
@yann-soubeyrand looks like I submitted additional fixes in #778, should we combine forces? |
yann-soubeyrand
added a commit
to camptocamp/terraform-github-actions-runner-provisioner
that referenced
this pull request
May 10, 2021
The modified provider includes the changes from integrations/terraform-provider-github#780.
This avoids propagating null values when the evaluation of the data source is deferred. Signed-off-by: Yann Soubeyrand <yann.soubeyrand@camptocamp.com>
yann-soubeyrand
force-pushed
the
data-repository-computed-fields
branch
from
d100a5f to
53eb4a9
Compare
yann-soubeyrand
added a commit
to camptocamp/terraform-github-actions-runner-provisioner
that referenced
this pull request
May 11, 2021
The modified provider includes the changes from integrations/terraform-provider-github#780.
|
@cnuss sorry, I didn’t see your PR. I’ve no strong opinion for or against joining forces, as long as these changes end up in a released provider ;-) |
|
Closing in favour of #778. @yann-soubeyrand please let me know if the new release does not fix your use case and I can get this one re-opened. |
jcudit
approved these changes
Jun 30, 2021
kfcampbell
pushed a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
…ntegrations#780) This avoids propagating null values when the evaluation of the data source is deferred. Signed-off-by: Yann Soubeyrand <yann.soubeyrand@camptocamp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids propagating null values when the evaluation of the data source is deferred.
In some rare situations where one is using the repository data source on a not yet existing repository (which will be created during terraform apply), the evaluation of this data source will be deferred. However, a resource using only its full_name attribute (if the name argument was set) or its name attribute (if the full_name argument was set), will immediately get a null value since these attributes are not set as computed. Setting these attributes to computed solves the problem.