Update go-github to v41 #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcudit
approved these changes
Dec 3, 2021
jcudit
reviewed
Dec 3, 2021
go.mod
Outdated
| @@ -5,7 +5,8 @@ go 1.16 | |||
| require ( | |||
| github.com/client9/misspell v0.3.4 | |||
| github.com/golangci/golangci-lint v1.25.1 | |||
| github.com/google/go-github/v39 v39.0.0 | |||
| github.com/google/go-github/v39 v39.2.0 | |||
There was a problem hiding this comment.
Should this be removed in favour of the version below?
There was a problem hiding this comment.
@jcudit I'm so sorry, I left out the second step! 🤦 It's all updated now and is ready for re-review. Please forgive me for the hassle.
jcudit
approved these changes
Jan 5, 2022
kfcampbell
added a commit
to kfcampbell/terraform-provider-github
that referenced
this pull request
Jul 26, 2022
* Initial commit of bumping go-github to v41 * Update code to use new release * Run go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're a few minor versions and 2 major versions behind. Luckily, the recent releases have all been pretty small changes and the breaking changes don't affect us. Let's update the library now so we don't fall further behind in the future!