Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update polkadot-v0.9.29 #103

Merged
merged 7 commits into from
Oct 20, 2022
Merged

Update polkadot-v0.9.29 #103

merged 7 commits into from
Oct 20, 2022

Conversation

OverOrion
Copy link
Contributor

No description provided.

@wangminqi
Copy link

wangminqi commented Oct 14, 2022 •
edited
Loading

paritytech/substrate#10174 (comment)
Make sure each custom pallet has at least a try-runtime feature flag:

try-runtime = [ "frame-support/try-runtime" ]

@OverOrion
Copy link
Contributor Author

Hi @wangminqi,

First of all thank you for pointing this out, and sorry for the late reply. I've added the try-runtime feature flag.

@OverOrion OverOrion force-pushed the szp/polkadot-v0.9.29 branch from 60d42b0 to 7ed3945 Compare October 19, 2022 10:19
@OverOrion OverOrion requested review from haerdib and coax1d October 19, 2022 11:56
haerdib
haerdib approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@haerdib haerdib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@haerdib haerdib mentioned this pull request Oct 19, 2022
Merged
@OverOrion OverOrion marked this pull request as ready for review October 20, 2022 08:17
@OverOrion OverOrion merged commit 76cda7d into master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haerdib haerdib haerdib approved these changes

@coax1d coax1d Awaiting requested review from coax1d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OverOrion @wangminqi @haerdib