Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attesteer RPC additions #1201
Attesteer RPC additions #1201
Changes from 12 commits
378652e
5862ee0
3865f59
296ce9c
ad76638
3b21f0a
5f1c56f
6e4a5c1
9a11f6b
3c184f4
74c7597
376dc0b
ac5fcc5
43aa983
554eea9
a7e5f80
e6cdacc
6875baa
c920561
5b94a6c
2cb4162
8d75580
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as explained below for the other command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as explained below for the other command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw. I know this is a pattern that you find in our codebase, but I honestly don't know how brought this into existence. And with rust v1.6.5 we can use a beautiful pattern here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not use the
let-else
pattern in some places (where the error would be reported ase
would not be defined otherwise). I usedmatch
expressions there, hope that's alright.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you messed up some stuff here:
ShardIdentifier
, which you don't pass in the request (which is fine). So the hex encoded params does only contain the hex encoded remote attestation. Hence, what you need to do is simply:Where are you sending the remote attestation to the chain? You just send back the ready to send extrinsic to the client. The attesteer should send it to the chain, though. Is this a programmatic error, or do we have a misunderstanding about what the attesteer should do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was the former, I fixed it accordingly in c920561.