Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[its-consensus-slots] fix flaky tests, which are due to parallelism #1469

Merged
merged 2 commits into from
Oct 13, 2023
Merged

[its-consensus-slots] fix flaky tests, which are due to parallelism #1469

merged 2 commits into from
Oct 13, 2023

Conversation

clangenb
Copy link
Contributor

@clangenb clangenb commented Oct 12, 2023 •
edited
Loading

I think I found out why we had a flaky yield next slot test, which was a combination of having a global LastSlot object, but parallel tests. Depending on the order of the tests, it could be a slot was yielded even though it shouldn't have. I ran the problematic test 15 times on my local machine, and it passed every time, and the CI was also green on the first try. Hence, I believe that it is fixed.

@clangenb clangenb added A0-core Affects a core part B0-silent Item should not be mentioned in any change logs. (e.g. documentation updates) C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing B1-releasenotes and removed B0-silent Item should not be mentioned in any change logs. (e.g. documentation updates) labels Oct 12, 2023
@clangenb clangenb merged commit 4c3bec1 into master Oct 13, 2023
21 checks passed
@clangenb clangenb deleted the cl/fix-flaky-slots branch October 13, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A0-core Affects a core part B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate yield_next_slot failure
1 participant
@clangenb