Fix ita-sgx-runtime standalone build and improve its Cargo.toml #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clangenb
added
A2-applibs
clangenb
force-pushed
the
cl/minor-fixes
branch
from
de440d9
to
a75836e
Compare
clangenb
commented
Feb 27, 2024
| @@ -246,7 +246,7 @@ jobs: | |||
| run: rustup show | |||
|
|
|||
| - name: Install taplo | |||
| run: cargo install taplo-cli --locked | |||
| run: cargo install --version 0.8.1 taplo-cli --locked | |||
There was a problem hiding this comment.
The newest taplo requires rustc-v1.7.1, which we don't have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when preparing the raffle-demo that sgx-runtime doesn't build by itself in std, the reason was missing std enablement, I fixed it by removing the unnecessary dependencies whatsoever.