Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Off-chain worker mode #858

Merged
merged 3 commits into from
Jul 21, 2022
Merged

Off-chain worker mode #858

merged 3 commits into from
Jul 21, 2022

Conversation

murerfel
Copy link
Contributor

@murerfel murerfel commented Jul 13, 2022 •
edited
Loading

  • Introduce cargo features (sidechain and offchain-worker) to distinguish between the two worker modes sidechain and offchain-worker.
  • These can be set in the build by the environment variable ADDITIONAL_WORKER_FEATURES.
  • CI is updated to build the worker in both modes. Integration tests are run only against the sidechain worker.

Corresponding documentation in the Integritee wiki is done in this PR: integritee-network/IntegriteeWiki#1

  • In order to merge: Need to update the branch protection settings for this repo, since the CI jobs have changed.

Part of #836

@murerfel murerfel mentioned this pull request Jul 13, 2022
Closed
@murerfel murerfel self-assigned this Jul 13, 2022
murerfel
murerfel commented Jul 14, 2022
View reviewed changes
core-primitives/settings/src/lib.rs Outdated Show resolved Hide resolved
core/offchain-worker-executor/src/executor.rs Show resolved Hide resolved
core/parentchain/block-import-dispatcher/src/immediate_dispatcher.rs Show resolved Hide resolved
core/parentchain/block-import-dispatcher/src/immediate_dispatcher.rs Show resolved Hide resolved
app-libs/stf/src/hash.rs Outdated Show resolved Hide resolved
service/src/interval_scheduling.rs Show resolved Hide resolved
service/src/main.rs Outdated Show resolved Hide resolved
service/src/parentchain_block_syncer.rs Show resolved Hide resolved
service/src/sidechain_setup.rs Show resolved Hide resolved
service/src/sync_state.rs Show resolved Hide resolved
@murerfel murerfel marked this pull request as ready for review July 14, 2022 08:30
@murerfel murerfel requested a review from clangenb July 14, 2022 08:30
clangenb
clangenb reviewed Jul 15, 2022
View reviewed changes
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and clean! I am very happy about this. I think the overall solution for the off-chain worker template became so much simpler now!

Only a few minor questions.

app-libs/stf/src/hash.rs Outdated Show resolved Hide resolved
core-primitives/top-pool-author/src/lib.rs Outdated Show resolved Hide resolved
core/offchain-worker-executor/src/error.rs Outdated Show resolved Hide resolved
core/offchain-worker-executor/src/executor.rs Show resolved Hide resolved
core/offchain-worker-executor/src/executor.rs Show resolved Hide resolved
enclave-runtime/src/lib.rs Outdated Show resolved Hide resolved
enclave-runtime/src/tls_ra/seal_handler.rs Show resolved Hide resolved
enclave-runtime/src/tls_ra/tests.rs Outdated Show resolved Hide resolved
enclave-runtime/src/tls_ra/tls_ra_server.rs Outdated Show resolved Hide resolved
service/src/interval_scheduling.rs Show resolved Hide resolved
@murerfel murerfel requested a review from clangenb July 18, 2022 11:32
@murerfel murerfel mentioned this pull request Jul 18, 2022
Closed
clangenb
clangenb approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Only one input, but I leave it at your discretion if you want to implement that.

core-primitives/hashing/Cargo.toml Show resolved Hide resolved
core-primitives/settings/src/worker_mode.rs Show resolved Hide resolved
core/parentchain/block-import-dispatcher/src/immediate_dispatcher.rs Show resolved Hide resolved
enclave-runtime/src/lib.rs Outdated Show resolved Hide resolved
enclave-runtime/src/tls_ra/tls_ra_server.rs Outdated Show resolved Hide resolved
@murerfel murerfel merged commit a9a5afd into master Jul 21, 2022
@murerfel murerfel deleted the fm/offchain-worker-mode branch July 21, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb approved these changes

Assignees

@murerfel murerfel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murerfel @clangenb