Skip to content

Commit

Permalink
[media] dw2102: combine su3000_state and s6x0_state into dw2102_state
Browse files Browse the repository at this point in the history
Two separate state structs are defined for different devices inside the
dw2102. Combine them, as both only contain one element.

This will also make it easier to further cleanup the driver.

Signed-off-by: Olli Salonen <olli.salonen@iki.fi>
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
  • Loading branch information
trsqr authored and mchehab committed Apr 3, 2015
1 parent 67e6590 commit 2c4ffe2
Showing 1 changed file with 7 additions and 10 deletions.
17 changes: 7 additions & 10 deletions drivers/media/usb/dvb-usb/dw2102.c
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,8 @@
"Please see linux/Documentation/dvb/ for more details " \
"on firmware-problems."

struct su3000_state {
struct dw2102_state {
u8 initialized;
};

struct s6x0_state {
int (*old_set_voltage)(struct dvb_frontend *f, fe_sec_voltage_t v);
};

Expand Down Expand Up @@ -887,7 +884,7 @@ static int su3000_streaming_ctrl(struct dvb_usb_adapter *adap, int onoff)

static int su3000_power_ctrl(struct dvb_usb_device *d, int i)
{
struct su3000_state *state = (struct su3000_state *)d->priv;
struct dw2102_state *state = (struct dw2102_state *)d->priv;
u8 obuf[] = {0xde, 0};

info("%s: %d, initialized %d\n", __func__, i, state->initialized);
Expand Down Expand Up @@ -973,7 +970,7 @@ static int s660_set_voltage(struct dvb_frontend *fe, fe_sec_voltage_t voltage)
{
struct dvb_usb_adapter *d =
(struct dvb_usb_adapter *)(fe->dvb->priv);
struct s6x0_state *st = (struct s6x0_state *)d->dev->priv;
struct dw2102_state *st = (struct dw2102_state *)d->dev->priv;

dw210x_set_voltage(fe, voltage);
if (st->old_set_voltage)
Expand Down Expand Up @@ -1295,7 +1292,7 @@ static int stv0288_frontend_attach(struct dvb_usb_adapter *d)

static int ds3000_frontend_attach(struct dvb_usb_adapter *d)
{
struct s6x0_state *st = (struct s6x0_state *)d->dev->priv;
struct dw2102_state *st = d->dev->priv;
u8 obuf[] = {7, 1};

d->fe_adap[0].fe = dvb_attach(ds3000_attach, &s660_ds3000_config,
Expand Down Expand Up @@ -1857,7 +1854,7 @@ static struct dvb_usb_device_properties dw3101_properties = {
static struct dvb_usb_device_properties s6x0_properties = {
.caps = DVB_USB_IS_AN_I2C_ADAPTER,
.usb_ctrl = DEVICE_SPECIFIC,
.size_of_priv = sizeof(struct s6x0_state),
.size_of_priv = sizeof(struct dw2102_state),
.firmware = S630_FIRMWARE,
.no_reconnect = 1,

Expand Down Expand Up @@ -1950,7 +1947,7 @@ static struct dvb_usb_device_description d632 = {
static struct dvb_usb_device_properties su3000_properties = {
.caps = DVB_USB_IS_AN_I2C_ADAPTER,
.usb_ctrl = DEVICE_SPECIFIC,
.size_of_priv = sizeof(struct su3000_state),
.size_of_priv = sizeof(struct dw2102_state),
.power_ctrl = su3000_power_ctrl,
.num_adapters = 1,
.identify_state = su3000_identify_state,
Expand Down Expand Up @@ -2015,7 +2012,7 @@ static struct dvb_usb_device_properties su3000_properties = {
static struct dvb_usb_device_properties t220_properties = {
.caps = DVB_USB_IS_AN_I2C_ADAPTER,
.usb_ctrl = DEVICE_SPECIFIC,
.size_of_priv = sizeof(struct su3000_state),
.size_of_priv = sizeof(struct dw2102_state),
.power_ctrl = su3000_power_ctrl,
.num_adapters = 1,
.identify_state = su3000_identify_state,
Expand Down

0 comments on commit 2c4ffe2

Please sign in to comment.