test: fix overflow on large files #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iomartin
requested review from
cfzhu,
XingHongChenIntel and
daweiq
as code owners
If the input is a large file and we allocate memory via malloc, we can cause an overflow when computing the comp_out_sz and decomp_out_sz (lines 4247 and 4250): test_arg[i].comp_out_sz = test_arg[i].src_sz * 2; test_arg[i].decomp_out_sz = test_arg[i].src_sz * 5; This would cause the associated mallocs to fail with ENOMEM. Fix this by using size_t. Also fix many other places where the variables from test_arg are copied into other variables. Signed-off-by: Martin Oliveira <martin.oliveira@eideticom.com>
iomartin
force-pushed
the
test/overflow
branch
from
039948d
to
ec77799
Compare
|
@iomartin , Very thanks for your patch, we will merge this patch in internal repo firstly and update to this repo when next release. |
|
Update 7536364 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the input is a large file and we allocate memory via malloc, we can cause an overflow when computing the comp_out_sz and decomp_out_sz (lines 4247 and 4250):
This would cause the associated mallocs to fail with ENOMEM.
Fix this by using size_t.
Also fix many other places where the variables from test_arg are copied into other variables.
Signed-off-by: Martin Oliveira martin.oliveira@eideticom.com