-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run the DML tests from GitHub Action intead of TeamCity build #199
base: main
Are you sure you want to change the base?
Conversation
make dmlc -j $CPUS || exit $? | ||
|
||
# Run the tests | ||
T126_JOBS=$CPUS DMLC_CC=/usr/itm/gcc/13.1.0/bin/gcc ./bin/test-runner --moduledirs modules/dmlc --suite modules/dmlc/test || exit $? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some paths are hard-coded to our env. Would it make sense to start with some of the paths overrideable, like
if [ -n "$(DMLC_CC)" ] ; then export DMLC_CC=/usr/itm/... ; fi
... and probably similar for PACKAGE_REPO
?
We can do the same later on request, of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is just a quick hack to get the box moved from TC into GH ; we`re still running (or I was assuming we would still be running) on our local runners where we have simicsmp adn /usr/itm/gcc .
If we want to run outside on generic runners, we must somehow package up a docker image (or an image diff that you apply to some standard ubuntu image) that provides a decent GCC and Simics Base. I don't know how to do that, so that will have to be done and resolved later.
In order for this to work we need to assign some self-hosted runners ; and I don't know how or to what extent we can do that in the (somehwat?) public DML repo. There must be some rules and restrictions here I guess. If you look here, there seems to be one internal intel runner availalbe; but it obviously don't know simicsmp so we need to solve that the. https://github.com/intel/device-modeling-language/actions/runners?tab=self-hosted The way I see it we have two options:
|
and there's a 3rd option: |
No description provided.