Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only load pre-parsed files that end with .dmlast #335

Conversation

mandolaerik
Copy link
Contributor

@mandolaerik mandolaerik commented Nov 6, 2024

  • Only load pre-parsed files that end with .dmlast

Copy link
Contributor

@lwaern-intel lwaern-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible.

@mandolaerik
Copy link
Contributor Author

W fast

@syssimics
Copy link
Contributor

Verification #14064698: ✅ pass

This ducks some weird problems with `nul` on Windows:
`nul` normalizes to `\.\\NUL\` and `\.\\NUL\ast` counts
as an existing file.
@mandolaerik mandolaerik force-pushed the pr/only-load-pre-parsed-files-that-end-with-dmlast branch from cb6fad5 to 8802c39 Compare November 6, 2024 18:12
@mandolaerik
Copy link
Contributor Author

W fast

@syssimics
Copy link
Contributor

Verification #14065746: ❌ fail

@mandolaerik mandolaerik merged commit 7ac6b94 into intel:main Nov 6, 2024
1 of 2 checks passed
@mandolaerik mandolaerik deleted the pr/only-load-pre-parsed-files-that-end-with-dmlast branch November 6, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants