-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Update IMEX version #270
Conversation
@@ -83,6 +83,12 @@ struct TilesArray { | |||
SmallVector<SmallVector<Value>> tileMatrix; | |||
}; | |||
|
|||
static xegpu::TensorDescType getTensorDescType(llvm::ArrayRef<int64_t> shape, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The IMEX has originally a single function like:
TensorDescType get(ArrayRef<int64_t> shape, Type type, int aaa = 1, bool bbb = true);
And they added another similar overload function:
TensorDescType get(ArrayRef<int64_t> shape, Type type, int aaa = 1, SomeOtherType bbb = {});
This makes the default arguments unusable, xegpu::TensorDescType::get(shape, elementType)
will end up with ambitious overloading error.
@leshikus @WangJialei-A It seems that updating llvm-imex commit hash will not trigger re-build of LLVM in CI? Would you please fix that? |
I think you just simply need to add push:
paths:
- cmake/llvm-version.txt
+ - cmake/llvm-version-imex.txt
- .github/workflows/build-llvm.yml
|
Co-authored-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Thanks for your suggestions, @dchigarev ! |
Current status: Test failed on f16_matmul_32x32.mlir |
There was a patch in the |
Many thanks, @dchigarev ! I have rebased that to the current HEAD of main branch of IMEX and it works. Are you interested in submitting your PR to IMEX upstream? |
Yes, will do |
The IMEX upstream has rebased its LLVM version to a recent commit (early August). In this PR, we update the LLVM commit for IMEX build and the IMEX commit as well. The IMEX commit points to the newest main-branch commit of the repo https://github.com/intel/mlir-extensions
For now, We don't need self-hosted IMEX fork.We still need a patch on IMEX at Menooker/mlir-extensions#1 from @dchigarev . Currently still using a forked IMEX, but the patch seems a bug fix and might be able to be pushed upstream.