Add an option for insert gpu allocs to treat allocations as gpu-native #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchigarev
reviewed
Sep 24, 2024
lib/gc/Transforms/GPU/Pipeline.cpp
Outdated
| @@ -76,7 +76,10 @@ void populateGPUPipeline(mlir::OpPassManager &pm) { | |||
| pm.addNestedPass<func::FuncOp>(createGpuMapParallelLoopsPass()); | |||
| pm.addNestedPass<func::FuncOp>(createParallelLoopToGpuPass()); | |||
|
|
|||
| pm.addNestedPass<func::FuncOp>(imex::createInsertGPUAllocsPass("opencl")); | |||
| imex::InsertGPUAllocsOptions insertGPUAllocsOption{ | |||
| /*clientAPI*/ "opencl", /*inRegions*/ false, /*isUsmArgs*/ true}; | |||
There was a problem hiding this comment.
can we make isUsmArgs a parameter of the pipeline?
There was a problem hiding this comment.
Yes! An option is added to the pipeline
zhczhong
force-pushed
the
zhicong/remove_cpy_in_args
branch
from
3906c28 to
9041a84
Compare
dchigarev
approved these changes
Sep 24, 2024
kurapov-peter
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track #344