Fboemer/ntt fix #58
Merged
Fboemer/ntt fix #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboemer
commented
Sep 1, 2021
| @@ -266,7 +266,7 @@ void ForwardTransformToBitReverseAVX512( | |||
| const uint64_t* W = &root_of_unity_powers[W_idx]; | |||
| const uint64_t* W_precon = &precon_root_of_unity_powers[W_idx]; | |||
|
|
|||
| if (input_mod_factor <= 2) { | |||
| if ((input_mod_factor <= 2) && (recursion_depth == 0)) { | |||
fboemer
commented
Sep 1, 2021
| @@ -35,7 +35,7 @@ static void BM_EltwiseFMAModAddNative(benchmark::State& state) { // NOLINT | |||
|
|
|||
| BENCHMARK(BM_EltwiseFMAModAddNative) | |||
| ->Unit(benchmark::kMicrosecond) | |||
| ->ArgsProduct({{1024, 8192, 16384}, {false, true}}); | |||
| ->ArgsProduct({{1024, 4096, 16384}, {false, true}}); | |||
There was a problem hiding this comment.
Just making parameters consistent with other benchmarks.
hamishun
approved these changes
Sep 1, 2021
Comment on lines
+253
to
+261
| std::random_device rd; | ||
| std::mt19937 gen(rd()); | ||
| std::uniform_int_distribution<uint64_t> distrib(1, modulus - 1); | ||
|
|
||
| for (size_t trial = 0; trial < num_trials; ++trial) { | ||
| std::vector<uint64_t> input64(N, 0); | ||
| for (size_t i = 0; i < N; ++i) { | ||
| input64[i] = distrib(gen); | ||
| } |
There was a problem hiding this comment.
This code block is repeated a few times. Would it be worth, refactoring into a helper function that returns a vector? Or, abstract away distrib and gen into a functor and use std::generate.
There was a problem hiding this comment.
Thanks for the suggestion. I've created https://jiratest.idoc.intel.com/browse/GLADE-79 to fix in a separate PR
fboemer
added a commit
that referenced
this pull request
Sep 2, 2021
* Fix NTT AVX512 implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug in AVX512 NTT that appeared in the IFMA implementation with primes close to 2**50. Added
bool prefer_small_primesparameter toGeneratePrimes()which is used to trigger the failing condition.