Fboemer/fix 32 bit invntt #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboemer
force-pushed
the
fboemer/fix-32-bit-invntt
branch
from
b230733 to
dda6c9a
Compare
jlhcrawford
approved these changes
Oct 6, 2021
GelilaSeifu
approved these changes
Oct 6, 2021
joserochh
pushed a commit
to joserochh/hexl
that referenced
this pull request
Oct 11, 2021
* Fix 32-bit AVX512DQ InvNTT * Refactor NTT tests for better coverage
joserochh
added a commit
that referenced
this pull request
Oct 11, 2021
Avoiding memcpy calls on NTT * Avoiding memcpys on Fwd NTT * Avoiding memcpy on INV NTT * Fixing some lines length * using only one out-of-place on first passes * Adding out-of-place for raddix 4 NTT * Adding gpg issue * Adding test cases for out place NTT * Removing commented code and testing GPG Signing * Fboemer/fix 32 bit invntt (#73) * Fix 32-bit AVX512DQ InvNT * Refactor NTT tests for better coverage * Added performance tips to README (#74) * small fix on test case (missed during merge) Co-authored-by: Fabian Boemer <fabian.boemer@intel.com>
fboemer
added a commit
that referenced
this pull request
Nov 8, 2021
* Fix 32-bit AVX512DQ InvNTT * Refactor NTT tests for better coverage
fboemer
added a commit
that referenced
this pull request
Nov 8, 2021
Avoiding memcpy calls on NTT * Avoiding memcpys on Fwd NTT * Avoiding memcpy on INV NTT * Fixing some lines length * using only one out-of-place on first passes * Adding out-of-place for raddix 4 NTT * Adding gpg issue * Adding test cases for out place NTT * Removing commented code and testing GPG Signing * Fboemer/fix 32 bit invntt (#73) * Fix 32-bit AVX512DQ InvNT * Refactor NTT tests for better coverage * Added performance tips to README (#74) * small fix on test case (missed during merge) Co-authored-by: Fabian Boemer <fabian.boemer@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix AVX512 NTT on moduli in the range [2^30, 2^31] (see https://jiratest.idoc.intel.com/browse/GLADE-147). Previously, these moduli values mapped to the 32-bit AVX512DQ NTT implementation. However, to prevent overflow, the 32-bit AVX512DQ NTT implementation should only be used for moduli < 2^30.
I've also added a wider coverage on the NTT unit-tests around 28-32 bits to prevent regression in the future.