Feature/add arm support #286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate operands, and we have to use switch()'ed versions
…e_byte_shift_m128()
This was referenced Dec 8, 2020
|
Based on the information on versioning, it might make more sense to base the PR on the
|
Closed
|
@hulksmaaash thanks for the suggestion, submitted #287 and closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the ARM NEON port up to par with the x86. It is based on PR272 (#272), however it can be pulled in on its own as it includes the changes. All tests pass on both ARM and x86 (obviously, we wouldn't want to break x86 functionality). As already described in PR272, x86-specific code has been abstracted away and arch specific code has been put into separate headers in src/util/arch/. This way, maintining arch-specific code of hyperscan and/or porting hyperscan to a new architecture (eg Power/RISC-V/etc) should now be much easier.
Please consider merging this PR.