Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: add image upgrade with env vars #1499

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

hj-johannes-lee
Copy link
Contributor

@hj-johannes-lee hj-johannes-lee commented Aug 8, 2023

Fixes: #1390

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023

Codecov Report

Merging #1499 (5bd1ff3) into main (ba3ded1) will decrease coverage by 0.11%.
Report is 2 commits behind head on main.
The diff coverage is 14.28%.

❗ Current head 5bd1ff3 differs from pull request most recent head 26bf615. Consider uploading reports for the commit 26bf615 to get more accurate results

@@            Coverage Diff             @@
##             main    #1499      +/-   ##
==========================================
- Coverage   49.58%   49.48%   -0.11%     
==========================================
  Files          42       42              
  Lines        4917     4923       +6     
==========================================
- Hits         2438     2436       -2     
- Misses       2339     2345       +6     
- Partials      140      142       +2     
Files Changed Coverage Δ
pkg/controllers/dlb/controller.go 17.35% <0.00%> (ø)
pkg/controllers/dsa/controller.go 6.77% <0.00%> (ø)
pkg/controllers/fpga/controller.go 16.66% <0.00%> (ø)
pkg/controllers/gpu/controller.go 47.70% <0.00%> (ø)
pkg/controllers/iaa/controller.go 6.77% <0.00%> (ø)
pkg/controllers/qat/controller.go 9.72% <0.00%> (ø)
pkg/controllers/sgx/controller.go 10.74% <0.00%> (ø)
pkg/controllers/reconciler.go 4.56% <28.57%> (+0.30%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hj-johannes-lee hj-johannes-lee force-pushed the PR-2023-026 branch 2 times, most recently from 2125e22 to 8c2731f Compare August 14, 2023 12:13
@hj-johannes-lee hj-johannes-lee marked this pull request as ready for review August 15, 2023 08:19
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change alone does not mean anything without proper documentation and the necessary Makefile changes to get CSVs properly generated.

The goal for 0.28 should be that when users have 0.27 installed via OLM from operatorhub.io, the 0.28 release will be seamlessly upgraded using this flow.

pkg/controllers/reconciler.go Outdated Show resolved Hide resolved
Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
…ages

Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
@tkatila
Copy link
Contributor

tkatila commented Sep 19, 2023

Stupid question: Is the _SHA setting left for the user? I see that the --use-image-digests defines the operator image as a digest, but nothing for the plugins.

@mythi
Copy link
Contributor

mythi commented Sep 19, 2023

Is the _SHA setting left for the user?

no, they will be part of the OLM bundle we set when we upload to operatorhub.io (or the OCP team uploads to redhat certification)

@tkatila
Copy link
Contributor

tkatila commented Sep 19, 2023

Is the _SHA setting left for the user?

no, they will be part of the OLM bundle we set when we upload to operatorhub.io (or the OCP team uploads to redhat certification)

Ok, by "user" I meant the user creating the bundle. So it's done manually, not by some makefile wizardry.

@mythi mythi merged commit 44cc057 into intel:main Sep 19, 2023
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support SHA Digests for container image in the device plugin CRD
5 participants