-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: add image upgrade with env vars #1499
Conversation
7fb373a
to
ddc8042
Compare
Codecov Report
@@ Coverage Diff @@
## main #1499 +/- ##
==========================================
- Coverage 49.58% 49.48% -0.11%
==========================================
Files 42 42
Lines 4917 4923 +6
==========================================
- Hits 2438 2436 -2
- Misses 2339 2345 +6
- Partials 140 142 +2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ddc8042
to
427c0d2
Compare
2125e22
to
8c2731f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change alone does not mean anything without proper documentation and the necessary Makefile
changes to get CSVs properly generated.
The goal for 0.28 should be that when users have 0.27 installed via OLM from operatorhub.io, the 0.28 release will be seamlessly upgraded using this flow.
8c2731f
to
2ee7d33
Compare
48ab242
to
63b0bde
Compare
979a741
to
e61bbf1
Compare
Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
…ages Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
Signed-off-by: Hyeongju Johannes Lee <hyeongju.lee@intel.com>
e61bbf1
to
26bf615
Compare
Stupid question: Is the _SHA setting left for the user? I see that the |
no, they will be part of the OLM bundle we set when we upload to operatorhub.io (or the OCP team uploads to redhat certification) |
Ok, by "user" I meant the user creating the bundle. So it's done manually, not by some makefile wizardry. |
Fixes: #1390