Remove #include sgx_urts.h from sgx_uswitchless #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sgx_uswitchless.h header is used in both trusted and untrusted contexts from transitive inclusions. The sgx_urts.h header is strictly an untrusted domain header. Users that depend on the untrusted runtime should not depend on the transitive include behavior to provide sgx_urts.h. Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
|
Looks good. Will wait for a better timing for merging the change in the coming week. |
llly
added a commit
to llly/linux-sgx
that referenced
this pull request
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sgx_uswitchless.h header is used in both trusted and untrusted
contexts from transitive inclusions. The sgx_urts.h header is strictly
an untrusted domain header. Users that depend on the untrusted runtime
should not depend on the transitive include behavior to provide
sgx_urts.h.
Signed-off-by: Dionna Glaze dionnaglaze@google.com