This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Add test for sycl::vec with std::byte #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirlaz
previously approved these changes
Sep 29, 2021
s-kanaev
previously approved these changes
Oct 1, 2021
maximdimakov
dismissed stale reviews from s-kanaev and vladimirlaz
via
9eb50ce
dm-vodopyanov
pushed a commit
to intel/llvm
that referenced
this pull request
Oct 1, 2021
sycl::byte is deprecated and std::byte must be used instead. sycl::vec has unsigned char data under the hood when sycl::byte (the sycl::byte is alias to uint8_t) is used. I added helper struct for explicit casting std::byte to uint8_t and vice versa. When std::byte is used in sycl::vec, vec's realization will use uint8_t for all the operations. The test : intel/llvm-test-suite#478 Signed-off-by: mdimakov maxim.dimakov@intel.com
|
precommit is failing due to problems that are not related to this patch. Fix in the #494 |
|
@maximdimakov please note that SYCL :: Basic/vector_byte.cpp has failed on CUDA |
|
@vladimirlaz I fixed problem with cuda |
vladimirlaz
approved these changes
Oct 5, 2021
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
* Add test for vec with std::byte * Clang-format fix * Added c++17 compile options * Remove assert from kernel * Clang-format fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In intel/llvm#4637 added support for std::byte in sycl::vec class. The test is aimed to check functionality of sycl::vec class with std::byte.
Signed-off-by: mdimakov maxim.dimakov@intel.com