Skip to content

Commit

Permalink
[SYCL][Graph] Disable flaky windows tests (#13966)
Browse files Browse the repository at this point in the history
Several of the SYCL-Graph E2E tests occasionally fail in CI on Windows
for unrelated PRs. We can replicate this locally with a lot of effort,
but have not yet been able to diagnose the root cause of find a fix.
Disable all the tests which have been documented as sporadically failing
on Windows at any point.

See related GitHub Issues:

* #13951
* #12941
* #11852
  • Loading branch information
EwanC authored May 30, 2024
1 parent f2a2de3 commit 0a4f036
Show file tree
Hide file tree
Showing 24 changed files with 72 additions and 10 deletions.
4 changes: 3 additions & 1 deletion sycl/test-e2e/Graph/Explicit/basic_usm.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
// Extra run to check for immediate-command-list in Level Zero
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
//

// Test is flaky on Windows, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_EXPLICIT

Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/Graph/Explicit/basic_usm_host.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@

// REQUIRES: aspect-usm_host_allocations

// Test is flaky on Windows, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_EXPLICIT

#include "../Inputs/basic_usm_host.cpp"
3 changes: 3 additions & 0 deletions sycl/test-e2e/Graph/Explicit/basic_usm_mixed.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
// REQUIRES: aspect-usm_host_allocations
// REQUIRES: aspect-usm_shared_allocations

// Test is flaky on Windows, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_EXPLICIT

#include "../Inputs/basic_usm_mixed.cpp"
3 changes: 3 additions & 0 deletions sycl/test-e2e/Graph/Explicit/basic_usm_shared.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@

// REQUIRES: aspect-usm_shared_allocations

// Test is flaky on Windows, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_EXPLICIT

#include "../Inputs/basic_usm_shared.cpp"
3 changes: 3 additions & 0 deletions sycl/test-e2e/Graph/Explicit/host_task2_multiple_roots.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
// Windows
// UNSUPPORTED: cuda && windows

// Test is flaky on Windows for all targets, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_EXPLICIT

#include "../Inputs/host_task2_multiple_roots.cpp"
3 changes: 3 additions & 0 deletions sycl/test-e2e/Graph/Explicit/host_task_multiple_deps.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@

// REQUIRES: aspect-usm_shared_allocations

// Test is flaky on Windows, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_EXPLICIT

#include "../Inputs/host_task_multiple_deps.cpp"
3 changes: 3 additions & 0 deletions sycl/test-e2e/Graph/Explicit/host_task_multiple_roots.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
// Windows
// UNSUPPORTED: cuda && windows

// Test is flaky on Windows for all targets, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_EXPLICIT

#include "../Inputs/host_task_multiple_roots.cpp"
4 changes: 3 additions & 1 deletion sycl/test-e2e/Graph/Explicit/multiple_exec_graphs.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
// Extra run to check for immediate-command-list in Level Zero
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
//

// Test is flaky on Windows, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_EXPLICIT

Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/Graph/Explicit/queue_constructor_usm.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
// Extra run to check for immediate-command-list in Level Zero
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}

// Test is flaky on Windows, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_EXPLICIT

#include "../Inputs/queue_constructor_usm.cpp"
4 changes: 3 additions & 1 deletion sycl/test-e2e/Graph/Explicit/queue_shortcuts.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
// Extra run to check for immediate-command-list in Level Zero
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
//

// Test is flaky on Windows, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_EXPLICIT

Expand Down
4 changes: 3 additions & 1 deletion sycl/test-e2e/Graph/Explicit/sub_graph.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
// Extra run to check for immediate-command-list in Level Zero
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
//

// Test is flaky on Windows, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_EXPLICIT

Expand Down
4 changes: 3 additions & 1 deletion sycl/test-e2e/Graph/RecordReplay/after_use.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
// Extra run to check for immediate-command-list in Level Zero
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
//

// Test is flaky on Windows, disable until it can be fixed
// UNSUPPORTED: windows

// This test attempts recording a set of kernels after they have already been
// executed once before.
Expand Down
4 changes: 3 additions & 1 deletion sycl/test-e2e/Graph/RecordReplay/barrier_with_work.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
// Extra run to check for immediate-command-list in Level Zero
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
//

// Test is flaky on Windows, disable until it can be fixed
// UNSUPPORTED: windows

#include "../graph_common.hpp"

Expand Down
4 changes: 3 additions & 1 deletion sycl/test-e2e/Graph/RecordReplay/basic_usm.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
// Extra run to check for immediate-command-list in Level Zero
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
//

// Test is flaky on Windows, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_RECORD_REPLAY

Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/Graph/RecordReplay/basic_usm_host.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@

// REQUIRES: aspect-usm_host_allocations

// Test is flaky on Windows, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_RECORD_REPLAY

#include "../Inputs/basic_usm_host.cpp"
3 changes: 3 additions & 0 deletions sycl/test-e2e/Graph/RecordReplay/basic_usm_mixed.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
// REQUIRES: aspect-usm_host_allocations
// REQUIRES: aspect-usm_shared_allocations

// Test is flaky on Windows, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_RECORD_REPLAY

#include "../Inputs/basic_usm_mixed.cpp"
3 changes: 3 additions & 0 deletions sycl/test-e2e/Graph/RecordReplay/basic_usm_shared.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@

// REQUIRES: aspect-usm_shared_allocations

// Test is flaky on Windows, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_RECORD_REPLAY

#include "../Inputs/basic_usm_shared.cpp"
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
// Windows
// UNSUPPORTED: cuda && windows

// Test is flaky on Windows for all targets, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_RECORD_REPLAY

#include "../Inputs/host_task2_multiple_roots.cpp"
3 changes: 3 additions & 0 deletions sycl/test-e2e/Graph/RecordReplay/host_task_multiple_deps.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@

// REQUIRES: aspect-usm_shared_allocations

// Test is flaky on Windows, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_RECORD_REPLAY

#include "../Inputs/host_task_multiple_deps.cpp"
3 changes: 3 additions & 0 deletions sycl/test-e2e/Graph/RecordReplay/host_task_multiple_roots.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
// Windows
// UNSUPPORTED: cuda && windows

// Test is flaky on Windows for all targets, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_RECORD_REPLAY

#include "../Inputs/host_task_multiple_roots.cpp"
4 changes: 3 additions & 1 deletion sycl/test-e2e/Graph/RecordReplay/multiple_exec_graphs.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
// Extra run to check for immediate-command-list in Level Zero
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
//

// Test is flaky on Windows, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_RECORD_REPLAY

Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/Graph/RecordReplay/queue_constructor_usm.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
// Extra run to check for immediate-command-list in Level Zero
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}

// Test is flaky on Windows, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_RECORD_REPLAY

#include "../Inputs/queue_constructor_usm.cpp"
4 changes: 3 additions & 1 deletion sycl/test-e2e/Graph/RecordReplay/queue_shortcuts.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
// Extra run to check for immediate-command-list in Level Zero
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
//

// Test is flaky on Windows, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_RECORD_REPLAY

Expand Down
4 changes: 3 additions & 1 deletion sycl/test-e2e/Graph/RecordReplay/sub_graph.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
// Extra run to check for immediate-command-list in Level Zero
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
//

// Test is flaky on Windows, disable until it can be fixed
// UNSUPPORTED: windows

#define GRAPH_E2E_RECORD_REPLAY

Expand Down

0 comments on commit 0a4f036

Please sign in to comment.