[SYCL] Fix test. Fix review comments.

Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
intel · Mar 10, 2020 · 68af609 · 68af609
1 parent 283b638
commit 68af609
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 18 deletions.
diff --git a/clang/test/SemaSYCL/call-to-undefined-function.cpp b/clang/test/SemaSYCL/call-to-undefined-function.cpp
@@ -1,7 +1,6 @@
 // RUN: %clang_cc1 -fsycl-is-device -verify -fsyntax-only %s
 
 void defined() {
-  // empty
 }
 
 void undefined();
@@ -16,7 +15,6 @@ __attribute__((sycl_kernel)) void kernel_single_task(Func kernelFunc) {
 
 template <typename T>
 void definedTpl() {
-  // empty
 }
 
 template <typename T>
@@ -28,67 +26,57 @@ extern SYCL_EXTERNAL void undefinedExternalTpl();
 
 template <typename T, bool X>
 void definedPartialTpl() {
-  // empty
 }
 
 template <>
 void definedPartialTpl<char, true>() {
-  // empty
 }
 
 template <typename T, bool X>
 struct Tpl {
   void defined() {
-    // empty
   }
 };
 
 template <typename T>
 struct Tpl<T, true> {
   void defined() {
-    // empty
   }
 };
 
 template <typename T, bool X>
 struct TplWithTplMethod {
   template <typename T2, bool Y>
   void defined() {
-    // empty
   }
 };
 
 template <typename T>
 struct TplWithTplMethod<T, true> {
   template <typename T2, bool Y>
   void defined() {
-    // empty
   }
 };
 
 template <typename T, bool X>
 struct TplWithTplMethod2 {
   template <typename T2, bool Y>
   void defined() {
-    // empty
   }
 
   template <>
   void defined<char, true>() {
-    // empty
   }
 };
 
 template <typename T>
 struct TplWithTplMethod2<T, true> {
   template <typename T2, bool Y>
   void defined() {
-    // empty
   }
 
   template <>
   void defined<char, true>() {
-    // empty
   }
 };
 
@@ -101,7 +89,6 @@ void useFwDeclFn() {
 }
 
 void forwardDeclFn() {
-  // empty
 }
 
 int main() {
@@ -179,5 +166,4 @@ int main() {
 }
 
 void forwardDeclFn2() {
-  // empty
 }
diff --git a/clang/test/SemaSYCL/deferred-diagnostics-emit.cpp b/clang/test/SemaSYCL/deferred-diagnostics-emit.cpp
@@ -16,7 +16,7 @@ __attribute__((sycl_kernel)) void kernel_single_task(Func kernelFunc) {
 } // namespace cl
 
 //variadic functions from SYCL kernels emit a deferred diagnostic
-void variadic(int, ...);
+void variadic(int, ...) {}
 
 int calledFromKernel(int a) {
   // expected-error@+1 {{zero-length arrays are not permitted in C++}}

diff --git a/clang/test/SemaSYCL/sycl-restrict.cpp b/clang/test/SemaSYCL/sycl-restrict.cpp
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -fcxx-exceptions -triple spir64 -fsycl-is-device -Wno-return-type -verify -fsyntax-only -std=c++17 -DSYCL_STRICT %s
+// RUN: %clang_cc1 -fcxx-exceptions -triple spir64 -fsycl-is-device -Wno-return-type -verify -fsyntax-only -std=c++17 %s
 // RUN: %clang_cc1 -fcxx-exceptions -triple spir64 -fsycl-is-device -fno-sycl-allow-func-ptr -Wno-return-type -verify -fsyntax-only -std=c++17 %s
 // RUN: %clang_cc1 -fcxx-exceptions -triple spir64 -fsycl-is-device -DALLOW_FP=1 -fsycl-allow-func-ptr -Wno-return-type -verify -fsyntax-only -std=c++17 %s
 

diff --git a/clang/test/SemaSYCL/sycl-varargs-cconv.cpp b/clang/test/SemaSYCL/sycl-varargs-cconv.cpp
@@ -1,5 +1,5 @@
-// The following runs only uses -Wno-sycl-strict to bypass SYCL_EXTERNAL applied
-// to funtion with raw pointer parameter
+// The following runs uses -Wno-sycl-strict to bypass SYCL_EXTERNAL applied to
+// funtion with raw pointer parameter
 // RUN: %clang_cc1 -fsycl-is-device -verify -Wno-sycl-strict -fsyntax-only %s
 // RUN: %clang_cc1 -fsycl-is-device -verify -Wno-sycl-strict -fsyntax-only -DPRINTF_INVALID_DEF %s
 // RUN: %clang_cc1 -fsycl-is-device -verify -fsyntax-only -Wno-sycl-strict -DPRINTF_INVALID_DECL %s