Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream SPIR-V built-ins declarations #1431

Open
Fznamznon opened this issue Mar 30, 2020 · 1 comment
Open

Upstream SPIR-V built-ins declarations #1431

Fznamznon opened this issue Mar 30, 2020 · 1 comment
Labels
upstream This change is related to upstreaming SYCL support to llorg.
Milestone
Upstream basic SY...

Comments

@Fznamznon
Copy link
Contributor

We have to upstream SPIR-V buit-ins declarations (enabled by #1384 ) to llorg. Otherwise we can't compile any SYCL sample using our SYCL headers and llorg clang:

.../build/bin/../include/sycl/CL/__spirv/spirv_ops.hpp:26:2: error: "SPIR-V built-ins are not available. Please set -fdeclare-spirv-builtins flag."
#error                                                                         \
 ^
@Fznamznon Fznamznon added the upstream This change is related to upstreaming SYCL support to llorg. label Mar 30, 2020
@bader
Copy link
Contributor

bader commented Mar 30, 2020

We can put an explicit header with the built-in declarations as a mitigation measure under ifdef and replace error directive with a warning/note.

vmaksimo pushed a commit to vmaksimo/llvm that referenced this issue Mar 9, 2022
@andreytr4intel @vmaksimo
Improve lit tests: replace hardcoded parameters with more robust and …
f31e464 
…reliable values (intel#1431)

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@7de9b5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream This change is related to upstreaming SYCL support to llorg.
Projects
None yet
Milestone
Upstream basic SYCL device front-end ...
Development

No branches or pull requests
2 participants
@bader @Fznamznon