Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of SPIR-V Translator patches that were reverted during pulldowns from Khronos repo #3686

Closed
vmaksimo opened this issue May 4, 2021 · 5 comments
Assignees
Labels
duplicate This issue or pull request already exists SPIR-V Issues related to SPIRV-LLVM-Translator

Comments

@vmaksimo
Copy link
Contributor

vmaksimo commented May 4, 2021

Should be enabled back once CPU RT is updated to new version:

Should be enabled once GPU driver is updated to new version:

@vmaksimo vmaksimo added the SPIR-V Issues related to SPIRV-LLVM-Translator label May 4, 2021
@vmaksimo vmaksimo self-assigned this May 4, 2021
@bader
Copy link
Contributor

bader commented May 11, 2021

WRT extensions: doesn't 2398c20 allows us to keep patches in?

@AlexeySachkov
Copy link
Contributor

WRT extensions: doesn't 2398c20 allows us to keep patches in?

Yes, it does, we can now re-apply patches with reverted extensions.

@vmaksimo
Copy link
Contributor Author

Re-applied in #3687

@vmaksimo
Copy link
Contributor Author

Unfortunately, re-applying of these patches caused regressions that were caught by llvm-test-suite. Will wait for a proper investigation and fix (maybe from @MrSidims)

@vmaksimo
Copy link
Contributor Author

This gap is tracked in #7592. Closing as a duplicate

@vmaksimo vmaksimo closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2022
@vmaksimo vmaksimo added the duplicate This issue or pull request already exists label Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists SPIR-V Issues related to SPIRV-LLVM-Translator
Projects
None yet
Development

No branches or pull requests

4 participants