Translate function attributes (incl. parameter attrs) for entry point kernels #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @airlied @MrSidims @AlexeySotkin to take a look |
|
LGTM |
MrSidims
approved these changes
Feb 16, 2022
svenvh
pushed a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Jun 21, 2022
… kernels (KhronosGroup#1409) * Restore `noalias` parameter attribute test check, removed in 7f168b2. * Restore the translation of function attributes and function parameter attributes for entry point kernels, accidentally dropped in 85815e7 "add an entry point wrapper around functions". (cherry picked from commit aded5af)
svenvh
pushed a commit
that referenced
this pull request
Jun 22, 2022
… kernels (#1409) * Restore `noalias` parameter attribute test check, removed in 7f168b2. * Restore the translation of function attributes and function parameter attributes for entry point kernels, accidentally dropped in 85815e7 "add an entry point wrapper around functions". (cherry picked from commit aded5af)
Quetzonarch
pushed a commit
to Quetzonarch/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 13, 2022
… kernels (KhronosGroup#1409) * Restore `noalias` parameter attribute test check, removed in 7f168b2. * Restore the translation of function attributes and function parameter attributes for entry point kernels, accidentally dropped in 85815e7 "add an entry point wrapper around functions".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noaliasparameter attribute test check, removed in 7f168b2.for entry point kernels, accidentally dropped in 85815e7 "add an entry point wrapper around functions".