[SYCL][CUDA] Remove size checks from USM allocations #10034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These checks are causing issues for very large USM allocations because the `MAX_MEM_ALLOC_SIZE` reported is lower than what CUDA actually supports. We will follow up with an update on the reported `MAX_MEM_ALLOC_SIZE`, but it makes sense to remove the checks either way, as the CUDA allocation functions will return an error if they can't allocate the memory.
kbenzie
approved these changes
Jun 22, 2023
callumfare
approved these changes
Jun 22, 2023
jchlanda
approved these changes
Jun 23, 2023
|
I had to fixup some of the assertions that were tripping up a test, but it's all fixed now |
jchlanda
approved these changes
Jun 27, 2023
callumfare
approved these changes
Jun 27, 2023
|
@intel/llvm-gatekeepers could we get some help merging this? thank you! |
fabiomestre
pushed a commit
to fabiomestre/llvm
that referenced
this pull request
Sep 26, 2023
These checks are causing issues for very large USM allocations because the `MAX_MEM_ALLOC_SIZE` reported is lower than what CUDA actually supports. We will follow up with an update on the reported `MAX_MEM_ALLOC_SIZE`, but it makes sense to remove the checks either way, as the CUDA allocation functions will return an error if they can't allocate the memory.
fabiomestre
pushed a commit
to fabiomestre/llvm
that referenced
this pull request
Sep 26, 2023
…intel#11023) Resolve same issue fixed in [PR](intel#10034) Co-authored-by: Omar Ahmed <omar.ahmed@codeplay.com>
fabiomestre
pushed a commit
to fabiomestre/unified-runtime
that referenced
this pull request
Sep 26, 2023
… (#11023) Resolve same issue fixed in [PR](intel/llvm#10034) Co-authored-by: Omar Ahmed <omar.ahmed@codeplay.com>
fabiomestre
pushed a commit
to oneapi-src/unified-runtime
that referenced
this pull request
Sep 27, 2023
… (#11023) Resolve same issue fixed in [PR](intel/llvm#10034) Co-authored-by: Omar Ahmed <omar.ahmed@codeplay.com>
omarahmed1111
added a commit
to omarahmed1111/unified-runtime
that referenced
this pull request
Oct 23, 2023
… (#11023) Resolve same issue fixed in [PR](intel/llvm#10034) Co-authored-by: Omar Ahmed <omar.ahmed@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These checks are causing issues for very large USM allocations because the
MAX_MEM_ALLOC_SIZEreported is lower than what CUDA actually supports.We will follow up with an update on the reported
MAX_MEM_ALLOC_SIZE, but it makes sense to remove the checks either way, as the CUDA allocation functions will return an error if they can't allocate the memory.