Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL] Make SYCL geometrical marray functions overloads instead of templates #10048

Merged
merged 3 commits into from
Jun 26, 2023
Merged

[SYCL] Make SYCL geometrical marray functions overloads instead of templates #10048

merged 3 commits into from
Jun 26, 2023

Conversation

KornevNikita
Copy link
Contributor

It was decided to change all built-in functions from templates to overloads. This patch changes marray part of "4.17.8. Geometric functions".

Non-marray part: #10014

Spec: KhronosGroup/SYCL-Docs#428

@KornevNikita KornevNikita requested a review from a team as a code owner June 23, 2023 12:41
@KornevNikita KornevNikita mentioned this pull request Jun 23, 2023
Merged
@KornevNikita KornevNikita temporarily deployed to aws June 23, 2023 12:59 — with GitHub Actions Inactive
@KornevNikita KornevNikita temporarily deployed to aws June 23, 2023 13:39 — with GitHub Actions Inactive
@KornevNikita KornevNikita temporarily deployed to aws June 23, 2023 14:31 — with GitHub Actions Inactive
@KornevNikita KornevNikita temporarily deployed to aws June 23, 2023 15:28 — with GitHub Actions Inactive
dm-vodopyanov pushed a commit that referenced this pull request Jun 25, 2023
@KornevNikita @steffenlarsen
[SYCL] Make SYCL geometrical functions overloads instead of templates (…
49bbcbf 
…#10014)

It was decided to change all built-in functions from templates to
overloads. This patch changes non-marray part of "4.17.8. Geometric
functions".

Marray part: #10048

Spec: KhronosGroup/SYCL-Docs#428

---------

Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
@KornevNikita KornevNikita temporarily deployed to aws June 26, 2023 08:04 — with GitHub Actions Inactive
@KornevNikita KornevNikita temporarily deployed to aws June 26, 2023 08:44 — with GitHub Actions Inactive
@dm-vodopyanov
Copy link
Contributor

Github is failing to receive the status of some pre-commit checks. Looking into these checks, they were completed successfully, so merging this PR.

@dm-vodopyanov dm-vodopyanov merged commit 3c95fc4 into intel:sycl Jun 26, 2023
@bader
Copy link
Contributor

bader commented Jun 26, 2023

Github is failing to receive the status of some pre-commit checks. Looking into these checks, they were completed successfully, so merging this PR.

Please, provide the links to the check logs.

@dm-vodopyanov
Copy link
Contributor

dm-vodopyanov commented Jun 27, 2023 •
edited
Loading

Github is failing to receive the status of some pre-commit checks. Looking into these checks, they were completed successfully, so merging this PR.

Please, provide the links to the check logs.

https://github.com/intel/llvm/actions/runs/5375236175/jobs/9751482338
https://github.com/intel/llvm/actions/runs/5375236175/jobs/9751482181
and
https://github.com/intel/llvm/actions/runs/5375236175/jobs/9751809445

Also noticed that in the same timeframe, one of post-commit checks for another patch finished successfully but status also didn't become green: https://github.com/intel/llvm/actions/runs/5374603367/jobs/9751217717

And there were no any reported incidents on Github side yesterday: https://www.githubstatus.com/history

steffenlarsen added a commit to steffenlarsen/llvm that referenced this pull request Jul 3, 2023
@steffenlarsen
Revert "[SYCL] Make SYCL geometrical marray functions overloads inste…
7246ee0 
…ad of templates (intel#10048)"

This reverts commit 3c95fc4.
@steffenlarsen steffenlarsen mentioned this pull request Jul 3, 2023
Merged
steffenlarsen added a commit that referenced this pull request Jul 3, 2023
@steffenlarsen
[SYCL] Temporarily revert recent SYCL builtin changes (#10173)
f109448 
This partially reverts the following patches:

- #9753
- #10050
- #10048
- #10014
- #10026

General fixes have been kept.

---------

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bso-intel bso-intel bso-intel approved these changes

@dm-vodopyanov dm-vodopyanov dm-vodopyanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KornevNikita @dm-vodopyanov @bader @bso-intel